[PATCH 0/3] regulator: misc fixes

Matti Vaittinen posted 3 patches 1 year, 9 months ago
drivers/regulator/bd71828-regulator.c | 58 +--------------------------
drivers/regulator/helpers.c           | 10 ++++-
drivers/regulator/rohm-regulator.c    |  4 ++
3 files changed, 14 insertions(+), 58 deletions(-)
[PATCH 0/3] regulator: misc fixes
Posted by Matti Vaittinen 1 year, 9 months ago
This series adds couple of a bit unrelated fixes/improvements which I
implemented while working to support yet another ROHM PMIC.

Patch1 addresses a potential problem where the voltage selector for
pickable-ranges is used in same fashion as a 'apply-bit'. Eg, when a
regulator voltage is changed so that also the range changes, the effect
of the range and voltage selector change is not taken into account until
the voltage selector is written to hardware. In such case caching the
voltage-selector value will cause the voltage range change to not change
the actual output voltage.

Patch2 is a fix to ROHM bd71818 and bd71879 low-power state specific
voltage settings where some of the voltages were common to many states.
The old behaviour was that changing voltage for one state caused it to
change for all states. This had a potential impact of accidentally
changing the runtime voltage when trying to configure voltage for a
low-power state, potentially hurting the boot-up process.

Patch3 is just a minor print improvement to help pinpointing unsupported
voltage in device-tree.

Series is based on v6.9

---

Matti Vaittinen (3):
  regulator: don't cache vsel to ensure voltage setting
  regulator: bd71828: Don't overwrite runtime voltages
  regulator: rohm-regulator: warn if unsupported voltage is set

 drivers/regulator/bd71828-regulator.c | 58 +--------------------------
 drivers/regulator/helpers.c           | 10 ++++-
 drivers/regulator/rohm-regulator.c    |  4 ++
 3 files changed, 14 insertions(+), 58 deletions(-)


base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
-- 
2.44.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
Re: [PATCH 0/3] regulator: misc fixes
Posted by Mark Brown 1 year, 9 months ago
On Thu, 16 May 2024 11:52:44 +0300, Matti Vaittinen wrote:
> This series adds couple of a bit unrelated fixes/improvements which I
> implemented while working to support yet another ROHM PMIC.
> 
> Patch1 addresses a potential problem where the voltage selector for
> pickable-ranges is used in same fashion as a 'apply-bit'. Eg, when a
> regulator voltage is changed so that also the range changes, the effect
> of the range and voltage selector change is not taken into account until
> the voltage selector is written to hardware. In such case caching the
> voltage-selector value will cause the voltage range change to not change
> the actual output voltage.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/3] regulator: don't cache vsel to ensure voltage setting
      (no commit info)
[2/3] regulator: bd71828: Don't overwrite runtime voltages
      commit: 0f9f7c63c415e287cd57b5c98be61eb320dedcfc
[3/3] regulator: rohm-regulator: warn if unsupported voltage is set
      commit: cb3a0f84ae0caa5eabf40457485473edc1e2d3f0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark