[PATCH v7 1/3] PNP: Add dev_is_pnp() macro

Guanbing Huang posted 3 patches 1 year, 10 months ago
There is a newer version of this series
[PATCH v7 1/3] PNP: Add dev_is_pnp() macro
Posted by Guanbing Huang 1 year, 10 months ago
From: Guanbing Huang <albanhuang@tencent.com>

Add dev_is_pnp() macro to determine whether the device is a PNP device.

Signed-off-by: Guanbing Huang <albanhuang@tencent.com>
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bing Fan <tombinfan@tencent.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404100523.b06UvPSB-lkp@intel.com/
Tested-by: Linheng Du <dylanlhdu@tencent.com>
---
v6 -> v7: add a "Reviewed-by" tag and a "Reported-by" tag, fix build errors when CONFIG_PNP is not enabled
v5 -> v6: fix the issue that the cover letter is not chained with the patch series
v4 -> v5: change "pnp" in the commit message to uppercase

 include/linux/pnp.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/pnp.h b/include/linux/pnp.h
index ddbe7c3ca4ce..82561242cda4 100644
--- a/include/linux/pnp.h
+++ b/include/linux/pnp.h
@@ -469,6 +469,8 @@ int compare_pnp_id(struct pnp_id *pos, const char *id);
 int pnp_register_driver(struct pnp_driver *drv);
 void pnp_unregister_driver(struct pnp_driver *drv);
 
+#define dev_is_pnp(d) ((d)->bus == &pnp_bus_type)
+
 #else
 
 /* device management */
@@ -500,6 +502,8 @@ static inline int compare_pnp_id(struct pnp_id *pos, const char *id) { return -E
 static inline int pnp_register_driver(struct pnp_driver *drv) { return -ENODEV; }
 static inline void pnp_unregister_driver(struct pnp_driver *drv) { }
 
+#define dev_is_pnp(d) false
+
 #endif /* CONFIG_PNP */
 
 /**
-- 
2.17.1
Re: [PATCH v7 1/3] PNP: Add dev_is_pnp() macro
Posted by Andy Shevchenko 1 year, 10 months ago
On Fri, Apr 12, 2024 at 11:24:12AM +0800, Guanbing Huang wrote:

...

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I haven't given this tag _explicitly_ as it's a new code and I answered in
the previous email that I will give one for the new version.

...

> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404100523.b06UvPSB-lkp@intel.com/

No, the new feature can't be reported.

...

Please, try again.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v7 1/3] PNP: Add dev_is_pnp() macro
Posted by Andy Shevchenko 1 year, 10 months ago
On Fri, Apr 12, 2024 at 06:29:56PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 11:24:12AM +0800, Guanbing Huang wrote:

...

> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I haven't given this tag _explicitly_ as it's a new code and I answered in
> the previous email that I will give one for the new version.
> 
> ...
> 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404100523.b06UvPSB-lkp@intel.com/
> 
> No, the new feature can't be reported.
> 
> ...
> 
> Please, try again.

To clarify, remove the above lines from your first commit.
If you want, you may leave my Rb tags in the patches 2 & 3
as code wasn't changed there.

-- 
With Best Regards,
Andy Shevchenko