[v2] ALSA: hda/tas2781: fixes for 6.9-rc1

[PATCH v2 0/4] ALSA: hda/tas2781: fixes for 6.9-rc1

Posted by Gergo Koteles 1 year, 10 months ago

Hi,

This series removes the no longer needed digital gain kcontrol, which 
caused problems in tas2563, because the register does not exists there.

This series also adds locking and debug statements to the other 
kcontrols. They sometimes ran in parallel with tasdev_fw_ready, and 
caused weird sound problems.
https://github.com/tomsom/yoga-linux/issues/58

Regards,
Gergo

Changes in v2:
 - Do not remove dvc_tlv scale from tas2781-tlv.h as it is also used by
   sound/soc/codecs/tas2781-i2c.c
 - Add kcontrol name to debug statements
 - Add a new patch to remove a useless debug statement.

[1]: https://lore.kernel.org/all/cover.1711401621.git.soyer@irl.hu/

Gergo Koteles (4):
  ALSA: hda/tas2781: remove digital gain kcontrol
  ALSA: hda/tas2781: add locks to kcontrols
  ALSA: hda/tas2781: add debug statements to kcontrols
  ALSA: hda/tas2781: remove useless dev_dbg from playback_hook

 sound/pci/hda/tas2781_hda_i2c.c | 118 +++++++++++++++++++++-----------
 1 file changed, 77 insertions(+), 41 deletions(-)


base-commit: 4cece764965020c22cff7665b18a012006359095
-- 
2.44.0

Re: [PATCH v2 0/4] ALSA: hda/tas2781: fixes for 6.9-rc1

Posted by Takashi Iwai 1 year, 10 months ago

On Tue, 26 Mar 2024 17:18:44 +0100,
Gergo Koteles wrote:
> 
> Hi,
> 
> This series removes the no longer needed digital gain kcontrol, which 
> caused problems in tas2563, because the register does not exists there.
> 
> This series also adds locking and debug statements to the other 
> kcontrols. They sometimes ran in parallel with tasdev_fw_ready, and 
> caused weird sound problems.
> https://github.com/tomsom/yoga-linux/issues/58
> 
> Regards,
> Gergo
> 
> Changes in v2:
>  - Do not remove dvc_tlv scale from tas2781-tlv.h as it is also used by
>    sound/soc/codecs/tas2781-i2c.c
>  - Add kcontrol name to debug statements
>  - Add a new patch to remove a useless debug statement.
> 
> [1]: https://lore.kernel.org/all/cover.1711401621.git.soyer@irl.hu/
> 
> Gergo Koteles (4):
>   ALSA: hda/tas2781: remove digital gain kcontrol
>   ALSA: hda/tas2781: add locks to kcontrols
>   ALSA: hda/tas2781: add debug statements to kcontrols
>   ALSA: hda/tas2781: remove useless dev_dbg from playback_hook

Applied now.  Thanks.


Takashi