iommufd: Fix three bugs found by Syzkaller

[PATCH rc 0/3] iommufd: Fix three bugs found by Syzkaller

Posted by Nicolin Chen 1 year, 11 months ago

Jason has been running Syzkaller that found three bugs.

Fix them properly.

Nicolin Chen (3):
  iommufd: Fix iopt_access_list_id overwrite bug
  iommufd/selftest: Fix mock_dev_num bug
  iommufd: Fix protection fault in iommufd_test_syz_conv_iova

 drivers/iommu/iommufd/io_pagetable.c |  9 ++++---
 drivers/iommu/iommufd/selftest.c     | 40 +++++++++++++++++++++-------
 2 files changed, 36 insertions(+), 13 deletions(-)

-- 
2.43.0

Re: [PATCH rc 0/3] iommufd: Fix three bugs found by Syzkaller

Posted by Jason Gunthorpe 1 year, 11 months ago

On Thu, Feb 22, 2024 at 01:23:44PM -0800, Nicolin Chen wrote:
> Jason has been running Syzkaller that found three bugs.
> 
> Fix them properly.
> 
> Nicolin Chen (3):
>   iommufd: Fix iopt_access_list_id overwrite bug
>   iommufd/selftest: Fix mock_dev_num bug
>   iommufd: Fix protection fault in iommufd_test_syz_conv_iova
> 
>  drivers/iommu/iommufd/io_pagetable.c |  9 ++++---
>  drivers/iommu/iommufd/selftest.c     | 40 +++++++++++++++++++++-------
>  2 files changed, 36 insertions(+), 13 deletions(-)

Applied to for-rc

Thanks,
Jason

RE: [PATCH rc 0/3] iommufd: Fix three bugs found by Syzkaller

Posted by Tian, Kevin 1 year, 11 months ago

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Friday, February 23, 2024 5:24 AM
> 
> Jason has been running Syzkaller that found three bugs.

could you remove "Jason has been running" from all three patches?
Just say that Syzkaller found a bug.

> 
> Fix them properly.
> 
> Nicolin Chen (3):
>   iommufd: Fix iopt_access_list_id overwrite bug
>   iommufd/selftest: Fix mock_dev_num bug
>   iommufd: Fix protection fault in iommufd_test_syz_conv_iova
> 
>  drivers/iommu/iommufd/io_pagetable.c |  9 ++++---
>  drivers/iommu/iommufd/selftest.c     | 40 +++++++++++++++++++++-------
>  2 files changed, 36 insertions(+), 13 deletions(-)
> 

otherwise all look good to me:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Re: [PATCH rc 0/3] iommufd: Fix three bugs found by Syzkaller

Posted by Jason Gunthorpe 1 year, 11 months ago

On Tue, Feb 27, 2024 at 03:34:11AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Friday, February 23, 2024 5:24 AM
> > 
> > Jason has been running Syzkaller that found three bugs.
> 
> could you remove "Jason has been running" from all three patches?
> Just say that Syzkaller found a bug.

I will copy edit the commit messages

Thanks,
Jason