[PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family

cy_huang@richtek.com posted 2 patches 1 year, 12 months ago
There is a newer version of this series
[PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family
Posted by cy_huang@richtek.com 1 year, 12 months ago
From: ChiYuan Huang <cy_huang@richtek.com>

Add compatible support for RTQ6053 and RTQ6059.

Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
 .../devicetree/bindings/iio/adc/richtek,rtq6056.yaml         | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
index 88e008629ea8..d1e1f36d1972 100644
--- a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml
@@ -25,7 +25,10 @@ description: |
 
 properties:
   compatible:
-    const: richtek,rtq6056
+    enum:
+      - richtek,rtq6053
+      - richtek,rtq6056
+      - richtek,rtq6059
 
   reg:
     maxItems: 1
-- 
2.34.1
Re: [PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family
Posted by Krzysztof Kozlowski 1 year, 12 months ago
On 28/12/2023 04:51, cy_huang@richtek.com wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
> 
> Add compatible support for RTQ6053 and RTQ6059.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>

Why do you resend the same patches after two days ignoring the feedback?
No versioning, no changelog?

NAK.

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof