parport: Convert to platform remove callback returning void

[PATCH 0/2] parport: Convert to platform remove callback returning void

Posted by Uwe Kleine-König 2 years ago

Hello,

this series converts all drivers below drivers/parport to use
.remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove
callback that returns no value") for an extended explanation and the
eventual goal. The TL;DR; is to make it harder for driver authors to
leak resources without noticing.

This is merge window material. The two patches are independent of each
other, so they could be applied individually.

Best regards
Uwe

Uwe Kleine-König (2):
  parport: amiga: Convert to platform remove callback returning void
  parport: sunbpp: Convert to platform remove callback returning void

 drivers/parport/parport_amiga.c  | 5 ++---
 drivers/parport/parport_sunbpp.c | 6 ++----
 2 files changed, 4 insertions(+), 7 deletions(-)


base-commit: ceb2fe0d438644e1de06b9a6468a1fb8e2199c70
-- 
2.42.0

Re: [PATCH 0/2] parport: Convert to platform remove callback returning void

Posted by Uwe Kleine-König 1 year, 10 months ago

Hello,

[Cc += gregkh]

On Mon, Dec 18, 2023 at 10:05:17PM +0100, Uwe Kleine-König wrote:
> this series converts all drivers below drivers/parport to use
> .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove
> callback that returns no value") for an extended explanation and the
> eventual goal. The TL;DR; is to make it harder for driver authors to
> leak resources without noticing.
> 
> This is merge window material. The two patches are independent of each
> other, so they could be applied individually.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (2):
>   parport: amiga: Convert to platform remove callback returning void
>   parport: sunbpp: Convert to platform remove callback returning void

I got no feedback for these patches since they were sent two months ago
:-\ 

Looking at the last patches to drivers/parport, they were merged by
Greg. Given the patches weren't sent to him, should I resend?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Re: [PATCH 0/2] parport: Convert to platform remove callback returning void

Posted by Greg Kroah-Hartman 1 year, 10 months ago

On Thu, Feb 15, 2024 at 10:22:09PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> [Cc += gregkh]
> 
> On Mon, Dec 18, 2023 at 10:05:17PM +0100, Uwe Kleine-König wrote:
> > this series converts all drivers below drivers/parport to use
> > .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove
> > callback that returns no value") for an extended explanation and the
> > eventual goal. The TL;DR; is to make it harder for driver authors to
> > leak resources without noticing.
> > 
> > This is merge window material. The two patches are independent of each
> > other, so they could be applied individually.
> > 
> > Best regards
> > Uwe
> > 
> > Uwe Kleine-König (2):
> >   parport: amiga: Convert to platform remove callback returning void
> >   parport: sunbpp: Convert to platform remove callback returning void
> 
> I got no feedback for these patches since they were sent two months ago
> :-\ 
> 
> Looking at the last patches to drivers/parport, they were merged by
> Greg. Given the patches weren't sent to him, should I resend?

I can just take them directly from here, thanks!

greg k-h