w1: gpio: Some cleanup and simplifiction

[PATCH v2 0/3] w1: gpio: Some cleanup and simplifiction

Posted by Uwe Kleine-König 2 years ago

Hello,

v1 is available at
https://lore.kernel.org/r/20230525095624.615350-1-u.kleine-koenig@pengutronix.de.

The changes in this v2 since then are:

 - Fix a build problem in patch #3
 - Rebase to today's next

Best regards
Uwe

Uwe Kleine-König (3):
  w1: gpio: Don't use platform data for driver data
  w1: gpio: Drop unused enable_external_pullup from driver data
  w1: gpio: rename pointer to driver data from pdata to ddata

 drivers/w1/masters/w1-gpio.c | 118 +++++++++++++----------------------
 include/linux/w1-gpio.h      |  22 -------
 2 files changed, 42 insertions(+), 98 deletions(-)
 delete mode 100644 include/linux/w1-gpio.h


base-commit: 629a3b49f3f957e975253c54846090b8d5ed2e9b
-- 
2.42.0

Re: [PATCH v2 0/3] w1: gpio: Some cleanup and simplifiction

Posted by Krzysztof Kozlowski 2 years ago

On Mon, 04 Dec 2023 23:05:20 +0100, Uwe Kleine-König wrote:
> v1 is available at
> https://lore.kernel.org/r/20230525095624.615350-1-u.kleine-koenig@pengutronix.de.
> 
> The changes in this v2 since then are:
> 
>  - Fix a build problem in patch #3
>  - Rebase to today's next
> 
> [...]

Applied, thanks!

[1/3] w1: gpio: Don't use platform data for driver data
      https://git.kernel.org/krzk/linux-w1/c/9c0a5b3f9e55cf9a3dc85843666cae28adfdf7e3
[2/3] w1: gpio: Drop unused enable_external_pullup from driver data
      https://git.kernel.org/krzk/linux-w1/c/deaba3d687b7cb1a2868bd514fd665ee5efcaaf3
[3/3] w1: gpio: rename pointer to driver data from pdata to ddata
      https://git.kernel.org/krzk/linux-w1/c/0ca9223fe9f75dce6e5cd306c685ee687a0bbdeb

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH v2 0/3] w1: gpio: Some cleanup and simplifiction

Posted by Krzysztof Kozlowski 2 years ago

On 04/12/2023 23:05, Uwe Kleine-König wrote:
> Hello,
> 
> v1 is available at
> https://lore.kernel.org/r/20230525095624.615350-1-u.kleine-koenig@pengutronix.de.
> 
> The changes in this v2 since then are:
> 
>  - Fix a build problem in patch #3
>  - Rebase to today's next

  ✗ No key: openpgp/u.kleine-koenig@pengutronix.de

Are you sure you exported your key to openpgp and verified addresses?

Best regards,
Krzysztof

Re: [PATCH v2 0/3] w1: gpio: Some cleanup and simplifiction

Posted by Uwe Kleine-König 2 years ago

Hello Krzysztof,

On Thu, Dec 07, 2023 at 02:29:34PM +0100, Krzysztof Kozlowski wrote:
> On 04/12/2023 23:05, Uwe Kleine-König wrote:
> > Hello,
> > 
> > v1 is available at
> > https://lore.kernel.org/r/20230525095624.615350-1-u.kleine-koenig@pengutronix.de.
> > 
> > The changes in this v2 since then are:
> > 
> >  - Fix a build problem in patch #3
> >  - Rebase to today's next
> 
>   ✗ No key: openpgp/u.kleine-koenig@pengutronix.de
> 
> Are you sure you exported your key to openpgp and verified addresses?

Works for me:

$ gpg --locate-keys u.kleine-koenig@pengutronix.de
gpg: directory '/home/test/.gnupg' created
gpg: keybox '/home/test/.gnupg/pubring.kbx' created
gpg: /home/test/.gnupg/trustdb.gpg: trustdb created
gpg: key E2DCDD9132669BD6: public key "Uwe Kleine-König <u.kleine-koenig@pengutronix.de>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: no ultimately trusted keys found
pub   rsa4096 2010-06-15 [SC] [expires: 2024-06-21]
      0D2511F322BFAB1C1580266BE2DCDD9132669BD6
uid           [ unknown] Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
sub   rsa2048 2023-03-17 [A] [expires: 2025-03-16]
sub   rsa2048 2023-03-17 [S] [expires: 2025-03-16]
sub   rsa2048 2023-03-17 [E] [expires: 2025-03-16]

also https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git seems to
have the current key since commit 5151fbdbeb53 "Update E2DCDD9132669BD6
(Uwe Kleine-König)".

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Re: [PATCH v2 0/3] w1: gpio: Some cleanup and simplifiction

Posted by Krzysztof Kozlowski 2 years ago

On 07/12/2023 15:24, Uwe Kleine-König wrote:
> Hello Krzysztof,
> 
> On Thu, Dec 07, 2023 at 02:29:34PM +0100, Krzysztof Kozlowski wrote:
>> On 04/12/2023 23:05, Uwe Kleine-König wrote:
>>> Hello,
>>>
>>> v1 is available at
>>> https://lore.kernel.org/r/20230525095624.615350-1-u.kleine-koenig@pengutronix.de.
>>>
>>> The changes in this v2 since then are:
>>>
>>>  - Fix a build problem in patch #3
>>>  - Rebase to today's next
>>
>>   ✗ No key: openpgp/u.kleine-koenig@pengutronix.de
>>
>> Are you sure you exported your key to openpgp and verified addresses?
> 
> Works for me:
> 
> $ gpg --locate-keys u.kleine-koenig@pengutronix.de
> gpg: directory '/home/test/.gnupg' created
> gpg: keybox '/home/test/.gnupg/pubring.kbx' created
> gpg: /home/test/.gnupg/trustdb.gpg: trustdb created
> gpg: key E2DCDD9132669BD6: public key "Uwe Kleine-König <u.kleine-koenig@pengutronix.de>" imported
> gpg: Total number processed: 1
> gpg:               imported: 1
> gpg: no ultimately trusted keys found
> pub   rsa4096 2010-06-15 [SC] [expires: 2024-06-21]
>       0D2511F322BFAB1C1580266BE2DCDD9132669BD6
> uid           [ unknown] Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> sub   rsa2048 2023-03-17 [A] [expires: 2025-03-16]
> sub   rsa2048 2023-03-17 [S] [expires: 2025-03-16]
> sub   rsa2048 2023-03-17 [E] [expires: 2025-03-16]
> 
> also https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git seems to
> have the current key since commit 5151fbdbeb53 "Update E2DCDD9132669BD6
> (Uwe Kleine-König)".
> 

Huh, I think I misunderstood the message from b4. I thought it is trying
to get your key from keys.openpgp.org and your key is just not there.
Are you saying that it was looking only in my local keyring?

Best regards,
Krzysztof

Re: [PATCH v2 0/3] w1: gpio: Some cleanup and simplifiction

Posted by Uwe Kleine-König 2 years ago

Hello Krzysztof,

On Thu, Dec 07, 2023 at 03:27:57PM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2023 15:24, Uwe Kleine-König wrote:
> > Hello Krzysztof,
> > 
> > On Thu, Dec 07, 2023 at 02:29:34PM +0100, Krzysztof Kozlowski wrote:
> >> On 04/12/2023 23:05, Uwe Kleine-König wrote:
> >>> Hello,
> >>>
> >>> v1 is available at
> >>> https://lore.kernel.org/r/20230525095624.615350-1-u.kleine-koenig@pengutronix.de.
> >>>
> >>> The changes in this v2 since then are:
> >>>
> >>>  - Fix a build problem in patch #3
> >>>  - Rebase to today's next
> >>
> >>   ✗ No key: openpgp/u.kleine-koenig@pengutronix.de

I think "openpgp" isn't about the keys.openpgp.org keyserver, but just
the signature algorithm.

> >> Are you sure you exported your key to openpgp and verified addresses?
> > 
> > Works for me:
> > 
> > $ gpg --locate-keys u.kleine-koenig@pengutronix.de

FTR: This lookup used WKD, but my key is also on keys.openpgp.org.

> > gpg: directory '/home/test/.gnupg' created
> > gpg: keybox '/home/test/.gnupg/pubring.kbx' created
> > gpg: /home/test/.gnupg/trustdb.gpg: trustdb created
> > gpg: key E2DCDD9132669BD6: public key "Uwe Kleine-König <u.kleine-koenig@pengutronix.de>" imported
> > gpg: Total number processed: 1
> > gpg:               imported: 1
> > gpg: no ultimately trusted keys found
> > pub   rsa4096 2010-06-15 [SC] [expires: 2024-06-21]
> >       0D2511F322BFAB1C1580266BE2DCDD9132669BD6
> > uid           [ unknown] Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > sub   rsa2048 2023-03-17 [A] [expires: 2025-03-16]
> > sub   rsa2048 2023-03-17 [S] [expires: 2025-03-16]
> > sub   rsa2048 2023-03-17 [E] [expires: 2025-03-16]
> > 
> > also https://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git seems to
> > have the current key since commit 5151fbdbeb53 "Update E2DCDD9132669BD6
> > (Uwe Kleine-König)".
> 
> Huh, I think I misunderstood the message from b4. I thought it is trying
> to get your key from keys.openpgp.org and your key is just not there.
> Are you saying that it was looking only in my local keyring?

I didn't check how the keyhandling is implemented in b4, but I guess it
just calls gpg and leaves it to you to get my key into your keyring.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |