Add binding doc for fault IRQ. The fault IRQ will be
trigger for ECC,DPP,FSM error.
Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com>
---
Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 7bdb412a0185..e013cb51fb07 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -37,12 +37,14 @@ properties:
items:
- description: Combined signal for various interrupt events
- description: The interrupt that occurs when Rx exits the LPI state
+ - description: The interrupt that occurs when HW fault occurs
interrupt-names:
minItems: 1
items:
- const: macirq
- const: eth_lpi
+ - const: safety
clocks:
maxItems: 4
@@ -89,8 +91,9 @@ examples:
<&gcc GCC_ETH_PTP_CLK>,
<&gcc GCC_ETH_RGMII_CLK>;
interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "macirq", "eth_lpi";
+ <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "macirq", "eth_lpi", "safety";
rx-fifo-depth = <4096>;
tx-fifo-depth = <4096>;
--
2.25.1On 23/11/2023 12:38, Suraj Jaiswal wrote: > Add binding doc for fault IRQ. The fault IRQ will be > trigger for ECC,DPP,FSM error. > > Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com> > --- > Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > index 7bdb412a0185..e013cb51fb07 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -37,12 +37,14 @@ properties: > items: > - description: Combined signal for various interrupt events > - description: The interrupt that occurs when Rx exits the LPI state > + - description: The interrupt that occurs when HW fault occurs Adding required items is breaking the ABI and introducing new dtbs_check warnings. I don't see rationale for this in the commit msg. I don't see any fixes for the warnings, either. I am quite picky on this part, so to avoid wasting my time - are you 100% sure you do not introduce any new warning? Best regards, Krzysztof
hi Krzysztof, Sure . Will take care of dtbs_check warnings in the next patch . Thanks Suraj On 11/24/2023 1:48 PM, Krzysztof Kozlowski wrote: > On 23/11/2023 12:38, Suraj Jaiswal wrote: >> Add binding doc for fault IRQ. The fault IRQ will be >> trigger for ECC,DPP,FSM error. >> >> Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com> >> --- >> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> index 7bdb412a0185..e013cb51fb07 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> @@ -37,12 +37,14 @@ properties: >> items: >> - description: Combined signal for various interrupt events >> - description: The interrupt that occurs when Rx exits the LPI state >> + - description: The interrupt that occurs when HW fault occurs > > Adding required items is breaking the ABI and introducing new dtbs_check > warnings. I don't see rationale for this in the commit msg. > > I don't see any fixes for the warnings, either. I am quite picky on this > part, so to avoid wasting my time - are you 100% sure you do not > introduce any new warning? > > Best regards, > Krzysztof >
On Thu, 23 Nov 2023 17:23:20 +0530, Suraj Jaiswal wrote:
> Add binding doc for fault IRQ. The fault IRQ will be
> triggered for ECC, DPP, FSM error.
>
> Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/qcom,ethqos.example.dtb: ethernet@7a80000: interrupt-names:2: 'eth_lpi' was expected
from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/qcom,ethqos.example.dtb: ethernet@7a80000: Unevaluated properties are not allowed ('mdio', 'phy-handle', 'phy-mode', 'rx-fifo-depth', 'snps,reset-active-low', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,tso', 'tx-fifo-depth' were unexpected)
from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ff458955a24c0cb4ba41158b8b53fbef00c8237d.1700737841.git.quic_jsuraj@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
@Andrew getting warning as part of below check . Need to explore more why this is coming .
below warning is coming becuase of " interrupt-names = "macirq", "eth_lpi", "safety";" safety added here . If I remove safety they warning gone.
Looks like we have to define property "safety" somewhere else as well . I have already added safety in "interrupt-names:" list but still no help .
# make DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=net/qcom,ethqos.yaml dt_binding_check
LINT Documentation/devicetree/bindings
invalid config: unknown option "required" for rule "quoted-strings"
xargs: /usr/bin/yamllint: exited with status 255; aborting
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTEX Documentation/devicetree/bindings/net/qcom,ethqos.example.dts
DTC_CHK Documentation/devicetree/bindings/net/qcom,ethqos.example.dtb
/local/mnt/workspace/andrew/linux-next/Documentation/devicetree/bindings/net/qcom,ethqos.example.dtb: ethernet@7a80000: interrupt-names:2: 'eth_lpi' was expected
from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
/local/mnt/workspace/andrew/linux-next/Documentation/devicetree/bindings/net/qcom,ethqos.example.dtb: ethernet@7a80000: Unevaluated properties are not allowed ('mdio', 'phy-handle', 'phy-mode', 'rx-fifo-depth', 'snps,reset-active-low', 'snps,reset-delays-us', 'snps,reset-gpio', 'snps,tso', 'tx-fifo-depth' were unexpected)
from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
On 11/23/2023 5:23 PM, Suraj Jaiswal wrote:
> Add binding doc for fault IRQ. The fault IRQ will be
> triggered for ECC, DPP, FSM error.
>
> Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 7bdb412a0185..e013cb51fb07 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -37,12 +37,14 @@ properties:
> items:
> - description: Combined signal for various interrupt events
> - description: The interrupt that occurs when Rx exits the LPI state
> + - description: The interrupt that occurs when HW fault occurs
>
> interrupt-names:
> minItems: 1
> items:
> - const: macirq
> - const: eth_lpi
> + - const: safety
>
> clocks:
> maxItems: 4
> @@ -89,8 +91,9 @@ examples:
> <&gcc GCC_ETH_PTP_CLK>,
> <&gcc GCC_ETH_RGMII_CLK>;
> interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "macirq", "eth_lpi";
> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_lpi", "safety";
>
> rx-fifo-depth = <4096>;
> tx-fifo-depth = <4096>;
On 11/23/23 12:38, Suraj Jaiswal wrote: > Add binding doc for fault IRQ. The fault IRQ will be > trigger for ECC,DPP,FSM error. trigerred spaces after commas > > Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com> > --- You refer to the IRQ as "fault" in the commit messages, but call it "safety" in dt.. Any reason to that? Konrad
© 2016 - 2025 Red Hat, Inc.