Add bindings for the MediaTek PEXTP Ethernet SerDes PHY found in the
MediaTek MT7988 SoC which can operate at various interfaces modes:
* USXGMII
* 10GBase-R
* 5GBase-R
* 2500Base-X
* 1000Base-X
* Cisco SGMII (MAC side)
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
.../bindings/phy/mediatek,xfi-pextp.yaml | 71 +++++++++++++++++++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
diff --git a/Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml b/Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
new file mode 100644
index 0000000000000..948d5031af1e3
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/mediatek,xfi-pextp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek XFI PEXTP SerDes PHY
+
+maintainers:
+ - Daniel Golle <daniel@makrotopia.org>
+
+description: |
+ The MediaTek XFI PEXTP SerDes PHY provides the physical SerDes lanes
+ used by the MediaTek USXGMII PCS.
+
+properties:
+ $nodename:
+ pattern: "^phy@[0-9a-f]+$"
+
+ compatible:
+ const: mediatek,mt7988-xfi-pextp
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: XFI PHY clock
+
+ resets:
+ items:
+ - description: PEXTP reset
+
+ mediatek,usxgmii-performance-errata:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R
+ mode which needs a work-around in the driver. The work-around is
+ enabled using this flag.
+
+ "#phy-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - resets
+ - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mediatek,mt7988-clk.h>
+ #include <dt-bindings/reset/mediatek,mt7988-resets.h>
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ xfi_pextp0: phy@11f20000 {
+ compatible = "mediatek,mt7988-xfi-pextp";
+ reg = <0 0x11f20000 0 0x10000>;
+ clocks = <&topckgen CLK_TOP_XFI_PHY_0_XTAL_SEL>;
+ resets = <&watchdog MT7988_TOPRGU_XFI_PEXTP0_GRST>;
+ mediatek,usxgmii-performance-errata;
+ #phy-cells = <0>;
+ };
+ };
+
+...
--
2.42.1On Thu, Nov 09, 2023 at 09:50:55PM +0000, Daniel Golle wrote:
> Add bindings for the MediaTek PEXTP Ethernet SerDes PHY found in the
> MediaTek MT7988 SoC which can operate at various interfaces modes:
>
> * USXGMII
> * 10GBase-R
> * 5GBase-R
> * 2500Base-X
> * 1000Base-X
> * Cisco SGMII (MAC side)
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/phy/mediatek,xfi-pextp.yaml | 71 +++++++++++++++++++
> 1 file changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml b/Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
> new file mode 100644
> index 0000000000000..948d5031af1e3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/mediatek,xfi-pextp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek XFI PEXTP SerDes PHY
> +
> +maintainers:
> + - Daniel Golle <daniel@makrotopia.org>
> +
> +description: |
Don't need '|' here.
> + The MediaTek XFI PEXTP SerDes PHY provides the physical SerDes lanes
> + used by the MediaTek USXGMII PCS.
> +
> +properties:
> + $nodename:
> + pattern: "^phy@[0-9a-f]+$"
> +
> + compatible:
> + const: mediatek,mt7988-xfi-pextp
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: XFI PHY clock
> +
> + resets:
> + items:
> + - description: PEXTP reset
> +
> + mediatek,usxgmii-performance-errata:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R
> + mode which needs a work-around in the driver. The work-around is
> + enabled using this flag.
> +
> + "#phy-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> + - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mediatek,mt7988-clk.h>
> + #include <dt-bindings/reset/mediatek,mt7988-resets.h>
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + xfi_pextp0: phy@11f20000 {
Drop unused labels.
> + compatible = "mediatek,mt7988-xfi-pextp";
> + reg = <0 0x11f20000 0 0x10000>;
> + clocks = <&topckgen CLK_TOP_XFI_PHY_0_XTAL_SEL>;
> + resets = <&watchdog MT7988_TOPRGU_XFI_PEXTP0_GRST>;
> + mediatek,usxgmii-performance-errata;
> + #phy-cells = <0>;
> + };
> + };
> +
> +...
> --
> 2.42.1
On Thu, 09 Nov 2023 21:50:55 +0000, Daniel Golle wrote:
> Add bindings for the MediaTek PEXTP Ethernet SerDes PHY found in the
> MediaTek MT7988 SoC which can operate at various interfaces modes:
>
> * USXGMII
> * 10GBase-R
> * 5GBase-R
> * 2500Base-X
> * 1000Base-X
> * Cisco SGMII (MAC side)
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../bindings/phy/mediatek,xfi-pextp.yaml | 71 +++++++++++++++++++
> 1 file changed, 71 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.example.dts:18:18: fatal error: dt-bindings/clock/mediatek,mt7988-clk.h: No such file or directory
18 | #include <dt-bindings/clock/mediatek,mt7988-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/924c2c6316e6d51a17423eded3a2c5c5bbf349d2.1699565880.git.daniel@makrotopia.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
> + mediatek,usxgmii-performance-errata:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R
> + mode which needs a work-around in the driver. The work-around is
> + enabled using this flag.
Is there more details about this? I'm just wondering if this should be
based on the compatible, rather than a bool property.
Andrew
Hi Andrew, On Thu, Nov 09, 2023 at 10:55:55PM +0100, Andrew Lunn wrote: > > + mediatek,usxgmii-performance-errata: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R > > + mode which needs a work-around in the driver. The work-around is > > + enabled using this flag. > > Is there more details about this? I'm just wondering if this should be > based on the compatible, rather than a bool property. The vendor sources where this is coming from are here: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/a500d94cd47e279015ce22947e1ce396a7516598%5E%21/#F0 And I'm afraid this is as much detail as it gets. And yes, we could also base this on the compatible and just have two different ones for the two PEXTP instances found in MT7988. Let me know your conclusion in that regard. Cheers Daniel
On Thu, Nov 09, 2023 at 11:11:02PM +0000, Daniel Golle wrote: > Hi Andrew, > > On Thu, Nov 09, 2023 at 10:55:55PM +0100, Andrew Lunn wrote: > > > + mediatek,usxgmii-performance-errata: > > > + $ref: /schemas/types.yaml#/definitions/flag > > > + description: > > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R > > > + mode which needs a work-around in the driver. The work-around is > > > + enabled using this flag. > > > > Is there more details about this? I'm just wondering if this should be > > based on the compatible, rather than a bool property. > > The vendor sources where this is coming from are here: > > https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/a500d94cd47e279015ce22947e1ce396a7516598%5E%21/#F0 > > And I'm afraid this is as much detail as it gets. And yes, we could > also base this on the compatible and just have two different ones for > the two PEXTP instances found in MT7988. > Let me know your conclusion in that regard. I'd go with a property in this case unless you think there may be other per instance differences. Rob
© 2016 - 2024 Red Hat, Inc.