staging: rtl8192e: Convert array rx_ring[] to rx_ring

[PATCH 00/10] staging: rtl8192e: Convert array rx_ring[] to rx_ring

Philipp Hortmann posted 10 patches 2 years, 1 month ago

Download series mbox

.../staging/rtl8192e/rtl8192e/r8190P_def.h    |   2 -
.../staging/rtl8192e/rtl8192e/r8192E_dev.c    |   2 +-
.../staging/rtl8192e/rtl8192e/r8192E_phyreg.h |  62 +--------
drivers/staging/rtl8192e/rtl8192e/rtl_core.c  | 131 ++++++++----------
drivers/staging/rtl8192e/rtl8192e/rtl_core.h  |  10 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c     |  37 -----
drivers/staging/rtl8192e/rtl819x_Qos.h        |   1 -
drivers/staging/rtl8192e/rtl819x_TS.h         |   1 -
drivers/staging/rtl8192e/rtllib.h             |   1 -
9 files changed, 67 insertions(+), 180 deletions(-)

Expand all Fold all

[PATCH 00/10] staging: rtl8192e: Convert array rx_ring[] to rx_ring

Posted by Philipp Hortmann 2 years, 1 month ago

Remove some functions that always return false or zero.
Remove a loop that is always executed one time and convert arrays to variables.
Remove some unused constants.

Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
Transferred this patch over wlan connection of rtl8192e.

Philipp Hortmann (10):
  staging: rtl8192e: Remove HTIOTActIsDisableMCS14()
  staging: rtl8192e: Remove HTIOTActIsDisableMCS15()
  staging: rtl8192e: Remove HTIOTActIsDisableMCSTwoSpatialStream()
  staging: rtl8192e: Remove HTIOTActIsDisableEDCATurbo()
  staging: rtl8192e: Remove loops with constant MAX_RX_QUEUE
  staging: rtl8192e: Convert array rx_ring[] to variable rx_ring
  staging: rtl8192e: Convert array rx_buf[][] to array rx_buf[]
  staging: rtl8192e: Convert array rx_ring_dma[] to variable rx_ring_dma
  staging: rtl8192e: Convert array rx_idx[] to variable rx_idx
  staging: rtl8192e: Remove unused constants starting with MAX_RX_QUEUE

 .../staging/rtl8192e/rtl8192e/r8190P_def.h    |   2 -
 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |   2 +-
 .../staging/rtl8192e/rtl8192e/r8192E_phyreg.h |  62 +--------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c  | 131 ++++++++----------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.h  |  10 +-
 drivers/staging/rtl8192e/rtl819x_HTProc.c     |  37 -----
 drivers/staging/rtl8192e/rtl819x_Qos.h        |   1 -
 drivers/staging/rtl8192e/rtl819x_TS.h         |   1 -
 drivers/staging/rtl8192e/rtllib.h             |   1 -
 9 files changed, 67 insertions(+), 180 deletions(-)

-- 
2.42.0

Re: [PATCH 00/10] staging: rtl8192e: Convert array rx_ring[] to rx_ring

Posted by Dan Carpenter 2 years, 1 month ago

On Thu, Oct 26, 2023 at 07:43:26AM +0200, Philipp Hortmann wrote:
> Remove some functions that always return false or zero.
> Remove a loop that is always executed one time and convert arrays to variables.
> Remove some unused constants.
> 
> Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
> Transferred this patch over wlan connection of rtl8192e.
> 
> Philipp Hortmann (10):
>   staging: rtl8192e: Remove HTIOTActIsDisableMCS14()
>   staging: rtl8192e: Remove HTIOTActIsDisableMCS15()
>   staging: rtl8192e: Remove HTIOTActIsDisableMCSTwoSpatialStream()
>   staging: rtl8192e: Remove HTIOTActIsDisableEDCATurbo()
>   staging: rtl8192e: Remove loops with constant MAX_RX_QUEUE
>   staging: rtl8192e: Convert array rx_ring[] to variable rx_ring
>   staging: rtl8192e: Convert array rx_buf[][] to array rx_buf[]
>   staging: rtl8192e: Convert array rx_ring_dma[] to variable rx_ring_dma
>   staging: rtl8192e: Convert array rx_idx[] to variable rx_idx
>   staging: rtl8192e: Remove unused constants starting with MAX_RX_QUEUE
> 

Looks good to me.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter