[PATCH 3/3] staging: greybus: fixed prefer using ftrace warning

Nandha Kumar Singaram posted 3 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH 3/3] staging: greybus: fixed prefer using ftrace warning
Posted by Nandha Kumar Singaram 2 years, 1 month ago
Adhere to linux coding style. Reported by checkpatch.pl:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
---
 drivers/staging/greybus/bootrom.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
index a8efb86de140..79581457c4af 100644
--- a/drivers/staging/greybus/bootrom.c
+++ b/drivers/staging/greybus/bootrom.c
@@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle)
 {
 	struct gb_bootrom *bootrom = greybus_get_drvdata(bundle);
 
-	dev_dbg(&bundle->dev, "%s\n", __func__);
-
 	gb_connection_disable(bootrom->connection);
 
 	/* Disable timeouts */
-- 
2.25.1
Re: [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning
Posted by Greg Kroah-Hartman 2 years, 1 month ago
On Sun, Oct 22, 2023 at 03:42:26AM -0700, Nandha Kumar Singaram wrote:
> Adhere to linux coding style. Reported by checkpatch.pl:
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> ---
>  drivers/staging/greybus/bootrom.c | 2 --
>  1 file changed, 2 deletions(-)

Again, subject line should have "bootrom" in there somewhere, right?

thanks,

greg k-h
Re: [PATCH 3/3] staging: greybus: fixed prefer using ftrace warning
Posted by Nandha Kumar Singaram 2 years, 1 month ago
On Sun, Oct 22, 2023 at 01:19:33PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Oct 22, 2023 at 03:42:26AM -0700, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> > 
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
> > ---
> >  drivers/staging/greybus/bootrom.c | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Again, subject line should have "bootrom" in there somewhere, right?
> 
> thanks,
> 
> greg k-h

Will update and share the patchset again.

Thanks,
Nandha Kumar