[PATCH 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x)

Nandha Kumar Singaram posted 2 patches 2 years, 3 months ago
There is a newer version of this series
drivers/staging/qlge/qlge.h      | 388 +++++++++++++++----------------
drivers/staging/qlge/qlge_main.c |   8 +-
drivers/staging/qlge/qlge_mpi.c  |   2 +-
3 files changed, 199 insertions(+), 199 deletions(-)
[PATCH 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
Posted by Nandha Kumar Singaram 2 years, 3 months ago
This patchset performs code cleanup in qlge driver as per
linux coding style and may be applied in any sequence.

Nandha Kumar Singaram (2):
  staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
  staging: qlge: Replace the occurrences of (1<<x) by BIT(x)

 drivers/staging/qlge/qlge.h      | 388 +++++++++++++++----------------
 drivers/staging/qlge/qlge_main.c |   8 +-
 drivers/staging/qlge/qlge_mpi.c  |   2 +-
 3 files changed, 199 insertions(+), 199 deletions(-)

-- 
2.25.1
Re: [PATCH 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
Posted by Greg Kroah-Hartman 2 years, 3 months ago
On Tue, Oct 17, 2023 at 12:03:57PM -0700, Nandha Kumar Singaram wrote:
> This patchset performs code cleanup in qlge driver as per
> linux coding style and may be applied in any sequence.
> 
> Nandha Kumar Singaram (2):
>   staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
>   staging: qlge: Replace the occurrences of (1<<x) by BIT(x)

You have two different patches doing different things yet they have the
same identical subject lines.  That's not ok, sorry, please make unique
subject lines as obviously you are doing different things.

thanks,

greg k-h
Re: [PATCH 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
Posted by Nandha Kumar Singaram 2 years, 3 months ago
On Wed, Oct 18, 2023 at 03:28:30PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Oct 17, 2023 at 12:03:57PM -0700, Nandha Kumar Singaram wrote:
> > This patchset performs code cleanup in qlge driver as per
> > linux coding style and may be applied in any sequence.
> > 
> > Nandha Kumar Singaram (2):
> >   staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
> >   staging: qlge: Replace the occurrences of (1<<x) by BIT(x)
> 
> You have two different patches doing different things yet they have the
> same identical subject lines.  That's not ok, sorry, please make unique
> subject lines as obviously you are doing different things.
> 
> thanks,
> 
> greg k-h

Sorry greg, thanks for your feedback. Will update the patch

Regards,
Nandha Kumar Singaram