staging: rtl8192u: Mute checkpatch error

[PATCH 0/6] staging: rtl8192u: Mute checkpatch error

Posted by Gilbert Adikankwu 2 years, 2 months ago

Align descendant arguments to the open parenthesis as per the "Linux
Kernel coding style" in Documentation/process/coding-style.rst

Mute the following checkpatch error:

CHECK: Alignment should match open parenthesis

Gilbert Adikankwu (6):
  staging: rtl8192u: Align descendant arguments
  staging: rtl8192u: Align descendant arguments
  staging: rtl8192u: Align descendant arguments
  staging: rtl8192u: Align descendant arguments
  staging: rtl8192u: Align descendant arguments
  staging: rtl8192u: Align descendant arguments

 drivers/staging/rtl8192u/r8180_93cx6.c     |  4 ++--
 drivers/staging/rtl8192u/r8190_rtl8256.c   | 16 +++++++--------
 drivers/staging/rtl8192u/r8192U_core.c     | 20 +++++++++---------
 drivers/staging/rtl8192u/r8192U_dm.c       | 24 +++++++++++-----------
 drivers/staging/rtl8192u/r819xU_firmware.c |  4 ++--
 drivers/staging/rtl8192u/r819xU_phy.c      |  2 +-
 6 files changed, 35 insertions(+), 35 deletions(-)

-- 
2.34.1

Re: [PATCH 0/6] staging: rtl8192u: Mute checkpatch error

Posted by Julia Lawall 2 years, 2 months ago

"Mute checkpatch error" is not very informative.

julia

On Sun, 15 Oct 2023, Gilbert Adikankwu wrote:

> Align descendant arguments to the open parenthesis as per the "Linux
> Kernel coding style" in Documentation/process/coding-style.rst
>
> Mute the following checkpatch error:
>
> CHECK: Alignment should match open parenthesis
>
> Gilbert Adikankwu (6):
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>
>  drivers/staging/rtl8192u/r8180_93cx6.c     |  4 ++--
>  drivers/staging/rtl8192u/r8190_rtl8256.c   | 16 +++++++--------
>  drivers/staging/rtl8192u/r8192U_core.c     | 20 +++++++++---------
>  drivers/staging/rtl8192u/r8192U_dm.c       | 24 +++++++++++-----------
>  drivers/staging/rtl8192u/r819xU_firmware.c |  4 ++--
>  drivers/staging/rtl8192u/r819xU_phy.c      |  2 +-
>  6 files changed, 35 insertions(+), 35 deletions(-)
>
> --
> 2.34.1
>
>
>

Re: [PATCH 0/6] staging: rtl8192u: Mute checkpatch error

Posted by Philipp Hortmann 2 years, 2 months ago

On 10/15/23 17:52, Julia Lawall wrote:
> "Mute checkpatch error" is not very informative.
> 
> julia
> 
> On Sun, 15 Oct 2023, Gilbert Adikankwu wrote:
> 
>> Align descendant arguments to the open parenthesis as per the "Linux
>> Kernel coding style" in Documentation/process/coding-style.rst
>>
>> Mute the following checkpatch error:
>>
>> CHECK: Alignment should match open parenthesis
>>
>> Gilbert Adikankwu (6):
>>    staging: rtl8192u: Align descendant arguments
>>    staging: rtl8192u: Align descendant arguments
>>    staging: rtl8192u: Align descendant arguments
>>    staging: rtl8192u: Align descendant arguments
>>    staging: rtl8192u: Align descendant arguments
>>    staging: rtl8192u: Align descendant arguments
>>
>>   drivers/staging/rtl8192u/r8180_93cx6.c     |  4 ++--
>>   drivers/staging/rtl8192u/r8190_rtl8256.c   | 16 +++++++--------
>>   drivers/staging/rtl8192u/r8192U_core.c     | 20 +++++++++---------
>>   drivers/staging/rtl8192u/r8192U_dm.c       | 24 +++++++++++-----------
>>   drivers/staging/rtl8192u/r819xU_firmware.c |  4 ++--
>>   drivers/staging/rtl8192u/r819xU_phy.c      |  2 +-
>>   6 files changed, 35 insertions(+), 35 deletions(-)
>>
>> --
>> 2.34.1

Hi,

this driver is about to be removed.

Have a look at:

https://lore.kernel.org/linux-staging/20231014211051.GA29518@matrix-ESPRIMO-P710/T/#u

Thanks

Bye Philipp

Re: [PATCH 0/6] staging: rtl8192u: Mute checkpatch error

Posted by Greg KH 2 years, 2 months ago

On Sun, Oct 15, 2023 at 12:06:46PM +0100, Gilbert Adikankwu wrote:
> Align descendant arguments to the open parenthesis as per the "Linux
> Kernel coding style" in Documentation/process/coding-style.rst
> 
> Mute the following checkpatch error:
> 
> CHECK: Alignment should match open parenthesis
> 
> Gilbert Adikankwu (6):
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments
>   staging: rtl8192u: Align descendant arguments

You have 6 patches here, with identical subject lines, yet obviously
they do different things.  Please fix that up to have unique subjects.

thanks,

greg k-h