[PATCH 1/5] OPP: Fix formatting of if/else block

Viresh Kumar posted 5 patches 2 years, 2 months ago
[PATCH 1/5] OPP: Fix formatting of if/else block
Posted by Viresh Kumar 2 years, 2 months ago
Add {} to both if else blocks or none.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/opp/of.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index ae5c405bbf9a..85e2af3d6a49 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -208,9 +208,9 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
 		mutex_lock(&opp_table_lock);
 		list_add(&opp_table->lazy, &lazy_opp_tables);
 		mutex_unlock(&opp_table_lock);
-	}
-	else
+	} else {
 		_update_set_required_opps(opp_table);
+	}
 
 	goto put_np;
 
-- 
2.31.1.272.g89b43f80a514
Re: [PATCH 1/5] OPP: Fix formatting of if/else block
Posted by Ulf Hansson 2 years, 2 months ago
On Fri, 13 Oct 2023 at 10:48, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Add {} to both if else blocks or none.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe


> ---
>  drivers/opp/of.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index ae5c405bbf9a..85e2af3d6a49 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -208,9 +208,9 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
>                 mutex_lock(&opp_table_lock);
>                 list_add(&opp_table->lazy, &lazy_opp_tables);
>                 mutex_unlock(&opp_table_lock);
> -       }
> -       else
> +       } else {
>                 _update_set_required_opps(opp_table);
> +       }
>
>         goto put_np;
>
> --
> 2.31.1.272.g89b43f80a514
>