[v1] staging: rts5208: Fix checkpatch macro warnings

[PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings

Soumya Negi posted 2 patches 2 years, 2 months ago

Diff against v2

Only 0 patches received!

There is a newer version of this series

drivers/staging/rts5208/rtsx.c | 24 ++++++-------
drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
2 files changed, 52 insertions(+), 38 deletions(-)

Expand all Fold all

[PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings

Posted by Soumya Negi 2 years, 2 months ago

In the driver staging/rts5208, checkpatch.pl warns of possible precedence 
issues in the header rtsx.h because macro arguments are not parenthesized.
This patch set handles the respective macros differently(as needed) in 
each patch to fix the warnings. Patches can be applied in any order.

Soumya Negi (2):
  staging: rts5208: Refactor macros to static inline functions
  staging: rts5208: Remove macros scsi_lock(), scsi_unlock()

 drivers/staging/rts5208/rtsx.c | 24 ++++++-------
 drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
 2 files changed, 52 insertions(+), 38 deletions(-)

-- 
2.17.1

Re: [PATCH 0/2] staging: rts5208: Fix checkpatch macro warnings

Posted by Soumya Negi 2 years, 2 months ago

On Thu, Oct 12, 2023 at 05:50:21AM -0700, Soumya Negi wrote:
> In the driver staging/rts5208, checkpatch.pl warns of possible precedence 
> issues in the header rtsx.h because macro arguments are not parenthesized.
> This patch set handles the respective macros differently(as needed) in 
> each patch to fix the warnings. Patches can be applied in any order.
> 
> Soumya Negi (2):
>   staging: rts5208: Refactor macros to static inline functions
>   staging: rts5208: Remove macros scsi_lock(), scsi_unlock()
> 
>  drivers/staging/rts5208/rtsx.c | 24 ++++++-------
>  drivers/staging/rts5208/rtsx.h | 66 ++++++++++++++++++++--------------
>  2 files changed, 52 insertions(+), 38 deletions(-)

Please ignore this patch set. Its incomplete & the rest of the patches
were not sent successfully. I have successfuly resent the complete 
patchset(unchanged) as v2 with an explanation after --- in the cover patch.


> -- 
> 2.17.1
>