[RFC PATCH 4/6] mtd: blkdevs: set GENHD_FL_NO_NVMEM

Daniel Golle posted 6 patches 2 years, 5 months ago
There is a newer version of this series
[RFC PATCH 4/6] mtd: blkdevs: set GENHD_FL_NO_NVMEM
Posted by Daniel Golle 2 years, 5 months ago
As the MTD subsystem already acts as an NVMEM provider, emulated mtdblock
devices should not be considered NVMEM providers.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
 drivers/mtd/mtd_blkdevs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index ff18636e08897..82d5afba6a25a 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -362,6 +362,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
 		gd->flags |= GENHD_FL_NO_PART;
 	}
 
+	gd->flags |= GENHD_FL_NO_NVMEM;
 	set_capacity(gd, ((u64)new->size * tr->blksize) >> 9);
 
 	/* Create the request queue */
-- 
2.41.0
Re: [RFC PATCH 4/6] mtd: blkdevs: set GENHD_FL_NO_NVMEM
Posted by Miquel Raynal 2 years, 5 months ago
Hi Daniel,

daniel@makrotopia.org wrote on Wed, 19 Jul 2023 23:03:24 +0100:

> As the MTD subsystem already acts as an NVMEM provider, emulated mtdblock
> devices should not be considered NVMEM providers.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
>  drivers/mtd/mtd_blkdevs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index ff18636e08897..82d5afba6a25a 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -362,6 +362,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
>  		gd->flags |= GENHD_FL_NO_PART;
>  	}
>  
> +	gd->flags |= GENHD_FL_NO_NVMEM;
>  	set_capacity(gd, ((u64)new->size * tr->blksize) >> 9);
>  
>  	/* Create the request queue */

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl