[PATCH 3/3] ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ

Geert Uytterhoeven posted 3 patches 2 years, 7 months ago
[PATCH 3/3] ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ
Posted by Geert Uytterhoeven 2 years, 7 months ago
If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y,
CONFIG_MFD_WCD934X=n, CONFIG_REGMAP_IRQ=n:

    aarch64-linux-gnu-ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_codec_probe':
    wcd934x.c:(.text+0x33cc): undefined reference to `regmap_irq_get_virq'
    aarch64-linux-gnu-ld: sound/soc/codecs/wcd934x.o: in function `wcd934x_comp_probe':
    wcd934x.c:(.text+0x4cb0): undefined reference to `regmap_irq_get_virq'
    aarch64-linux-gnu-ld: wcd934x.c:(.text+0x4cc0): undefined reference to `regmap_irq_get_virq'
    aarch64-linux-gnu-ld: wcd934x.c:(.text+0x4cd0): undefined reference to `regmap_irq_get_virq'
    aarch64-linux-gnu-ld: wcd934x.c:(.text+0x4ce0): undefined reference to `regmap_irq_get_virq'
    aarch64-linux-gnu-ld: sound/soc/codecs/wcd934x.o:wcd934x.c:(.text+0x4cf0): more undefined references to `regmap_irq_get_virq' follow

Fix this by making SND_SOC_WCD934X select REGMAP_IRQ.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 2a62dbd5339e4a3a..958499050c8b6a3f 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1942,6 +1942,7 @@ config SND_SOC_WCD934X
 	tristate "WCD9340/WCD9341 Codec"
 	depends on COMMON_CLK
 	depends on SLIMBUS
+	select REGMAP_IRQ
 	select REGMAP_SLIMBUS
 	select SND_SOC_WCD_MBHC
 	depends on MFD_WCD934X || COMPILE_TEST
-- 
2.34.1
Re: [PATCH 3/3] ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ
Posted by Mark Brown 2 years, 7 months ago
On Thu, Jul 06, 2023 at 01:42:04PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y,
> CONFIG_MFD_WCD934X=n, CONFIG_REGMAP_IRQ=n:

There appears to be at best a marginal relationship between this and the
rest of the series, please don't group things needlessly like this, it
just creates spurious dependencies which complicates getting things
merged.
Re: [PATCH 3/3] ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ
Posted by Geert Uytterhoeven 2 years, 7 months ago
Hi Mark,

On Thu, Jul 6, 2023 at 2:09 PM Mark Brown <broonie@kernel.org> wrote:
> On Thu, Jul 06, 2023 at 01:42:04PM +0200, Geert Uytterhoeven wrote:
> > If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y,
> > CONFIG_MFD_WCD934X=n, CONFIG_REGMAP_IRQ=n:
>
> There appears to be at best a marginal relationship between this and the
> rest of the series, please don't group things needlessly like this, it
> just creates spurious dependencies which complicates getting things
> merged.

Well, unless you have CONFIG_REGMAP=y due to some other reason, you
won't reach the mentioned link error without applying [PATCH 2/3] first.

It doesn't hurt to apply this patch independently, though.
Do you want me to resend it (to your sound-persona) as a separate patch?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH 3/3] ASoC: codecs: SND_SOC_WCD934X should select REGMAP_IRQ
Posted by Mark Brown 2 years, 7 months ago
On Thu, Jul 06, 2023 at 02:15:57PM +0200, Geert Uytterhoeven wrote:

> Well, unless you have CONFIG_REGMAP=y due to some other reason, you
> won't reach the mentioned link error without applying [PATCH 2/3] first.

> It doesn't hurt to apply this patch independently, though.
> Do you want me to resend it (to your sound-persona) as a separate patch?

I've already split it out.