[v3] drm: shmobile: Fixes and enhancements

[PATCH v3 0/5] drm: shmobile: Fixes and enhancements

Posted by Geert Uytterhoeven 2 years, 8 months ago

	Hi all,

Currently, there are two drivers for the LCD controller on Renesas
SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs:
  1. sh_mobile_lcdcfb, using the fbdev framework,
  2. shmob_drm, using the DRM framework.
However, only the former driver can be used, as all platform support
integrates the former.  None of these drivers support DT-based systems.

This patch series is a first step to enable the SH-Mobile DRM driver for
Renesas ARM-based SH-Mobile and R-Mobile SoCs.  The next steps planned are
to (1) add DT support (works, but needs a hack due to lack of (2)), and (2)
convert the driver to atomic modesetting.

Changes compared to v2[1]:
  - Add Reviewed-by.

Changes compared to v1[2]:
  - Add Reviewed-by,
  - Drop dependency on ARM.

This has been tested on the R-Mobile A1-based Atmark Techno
Armadillo-800-EVA development board, using a temporary
platform-enablement patch[3].

Thanks for applying to drm-misc!

[1] https://lore.kernel.org/r/cover.1680273039.git.geert+renesas@glider.be/
[2] https://lore.kernel.org/r/cover.1681734821.git.geert+renesas@glider.be/
[3] https://lore.kernel.org/r/c03d4edbd650836bf6a96504df82338ec6d800ff.1680272980.git.geert+renesas@glider.be

Geert Uytterhoeven (5):
  drm: shmobile: Use %p4cc to print fourcc codes
  drm: shmobile: Add support for DRM_FORMAT_XRGB8888
  drm: shmobile: Switch to drm_crtc_init_with_planes()
  drm: shmobile: Add missing call to drm_fbdev_generic_setup()
  drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

 drivers/gpu/drm/shmobile/Kconfig           |  4 +--
 drivers/gpu/drm/shmobile/shmob_drm_crtc.c  | 35 +++++++++++++++++++---
 drivers/gpu/drm/shmobile/shmob_drm_drv.c   |  3 ++
 drivers/gpu/drm/shmobile/shmob_drm_kms.c   |  9 ++++--
 drivers/gpu/drm/shmobile/shmob_drm_plane.c |  5 ++++
 5 files changed, 48 insertions(+), 8 deletions(-)

-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH v3 0/5] drm: shmobile: Fixes and enhancements

Posted by Thomas Zimmermann 2 years, 8 months ago

Hi

Am 23.05.23 um 17:31 schrieb Geert Uytterhoeven:
> 	Hi all,
> 
> Currently, there are two drivers for the LCD controller on Renesas
> SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs:
>    1. sh_mobile_lcdcfb, using the fbdev framework,
>    2. shmob_drm, using the DRM framework.
> However, only the former driver can be used, as all platform support
> integrates the former.  None of these drivers support DT-based systems.
> 
> This patch series is a first step to enable the SH-Mobile DRM driver for
> Renesas ARM-based SH-Mobile and R-Mobile SoCs.  The next steps planned are
> to (1) add DT support (works, but needs a hack due to lack of (2)), and (2)
> convert the driver to atomic modesetting.
> 
> Changes compared to v2[1]:
>    - Add Reviewed-by.
> 
> Changes compared to v1[2]:
>    - Add Reviewed-by,
>    - Drop dependency on ARM.
> 
> This has been tested on the R-Mobile A1-based Atmark Techno
> Armadillo-800-EVA development board, using a temporary
> platform-enablement patch[3].
> 
> Thanks for applying to drm-misc!

It's all been reviewed. Do you want me to merge the patchset?

Best regards
Thomas

> 
> [1] https://lore.kernel.org/r/cover.1680273039.git.geert+renesas@glider.be/
> [2] https://lore.kernel.org/r/cover.1681734821.git.geert+renesas@glider.be/
> [3] https://lore.kernel.org/r/c03d4edbd650836bf6a96504df82338ec6d800ff.1680272980.git.geert+renesas@glider.be
> 
> Geert Uytterhoeven (5):
>    drm: shmobile: Use %p4cc to print fourcc codes
>    drm: shmobile: Add support for DRM_FORMAT_XRGB8888
>    drm: shmobile: Switch to drm_crtc_init_with_planes()
>    drm: shmobile: Add missing call to drm_fbdev_generic_setup()
>    drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms
> 
>   drivers/gpu/drm/shmobile/Kconfig           |  4 +--
>   drivers/gpu/drm/shmobile/shmob_drm_crtc.c  | 35 +++++++++++++++++++---
>   drivers/gpu/drm/shmobile/shmob_drm_drv.c   |  3 ++
>   drivers/gpu/drm/shmobile/shmob_drm_kms.c   |  9 ++++--
>   drivers/gpu/drm/shmobile/shmob_drm_plane.c |  5 ++++
>   5 files changed, 48 insertions(+), 8 deletions(-)
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: [PATCH v3 0/5] drm: shmobile: Fixes and enhancements

Posted by Geert Uytterhoeven 2 years, 8 months ago

Hi Thomas,

On Wed, May 24, 2023 at 1:42 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 23.05.23 um 17:31 schrieb Geert Uytterhoeven:
> > Currently, there are two drivers for the LCD controller on Renesas
> > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs:
> >    1. sh_mobile_lcdcfb, using the fbdev framework,
> >    2. shmob_drm, using the DRM framework.
> > However, only the former driver can be used, as all platform support
> > integrates the former.  None of these drivers support DT-based systems.
> >
> > This patch series is a first step to enable the SH-Mobile DRM driver for
> > Renesas ARM-based SH-Mobile and R-Mobile SoCs.  The next steps planned are
> > to (1) add DT support (works, but needs a hack due to lack of (2)), and (2)
> > convert the driver to atomic modesetting.
> >
> > Changes compared to v2[1]:
> >    - Add Reviewed-by.
> >
> > Changes compared to v1[2]:
> >    - Add Reviewed-by,
> >    - Drop dependency on ARM.
> >
> > This has been tested on the R-Mobile A1-based Atmark Techno
> > Armadillo-800-EVA development board, using a temporary
> > platform-enablement patch[3].
> >
> > Thanks for applying to drm-misc!
>
> It's all been reviewed. Do you want me to merge the patchset?

That would be great! Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 0/5] drm: shmobile: Fixes and enhancements

Posted by Thomas Zimmermann 2 years, 8 months ago


Am 24.05.23 um 13:54 schrieb Geert Uytterhoeven:
> Hi Thomas,
> 
> On Wed, May 24, 2023 at 1:42 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Am 23.05.23 um 17:31 schrieb Geert Uytterhoeven:
>>> Currently, there are two drivers for the LCD controller on Renesas
>>> SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs:
>>>     1. sh_mobile_lcdcfb, using the fbdev framework,
>>>     2. shmob_drm, using the DRM framework.
>>> However, only the former driver can be used, as all platform support
>>> integrates the former.  None of these drivers support DT-based systems.
>>>
>>> This patch series is a first step to enable the SH-Mobile DRM driver for
>>> Renesas ARM-based SH-Mobile and R-Mobile SoCs.  The next steps planned are
>>> to (1) add DT support (works, but needs a hack due to lack of (2)), and (2)
>>> convert the driver to atomic modesetting.
>>>
>>> Changes compared to v2[1]:
>>>     - Add Reviewed-by.
>>>
>>> Changes compared to v1[2]:
>>>     - Add Reviewed-by,
>>>     - Drop dependency on ARM.
>>>
>>> This has been tested on the R-Mobile A1-based Atmark Techno
>>> Armadillo-800-EVA development board, using a temporary
>>> platform-enablement patch[3].
>>>
>>> Thanks for applying to drm-misc!
>>
>> It's all been reviewed. Do you want me to merge the patchset?
> 
> That would be great! Thanks!

Done. Thanks for the patches.

> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)