vfio/ccw: Replace one-element array with flexible-array member

[PATCH 0/2][next] vfio/ccw: Replace one-element array with flexible-array member

Posted by Gustavo A. R. Silva 2 years, 8 months ago

Hi!

This small series aims to replace a one-element array with a
flexible-array member in struct vfio_ccw_parent.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/160
Link: https://github.com/KSPP/linux/issues/297
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]

Gustavo A. R. Silva (2):
  vfio/ccw: Replace one-element array with flexible-array member
  vfio/ccw: Use struct_size() helper

 drivers/s390/cio/vfio_ccw_drv.c     | 2 +-
 drivers/s390/cio/vfio_ccw_private.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2][next] vfio/ccw: Replace one-element array with flexible-array member

Posted by Alexander Gordeev 2 years, 8 months ago

On Mon, May 22, 2023 at 07:34:41PM -0600, Gustavo A. R. Silva wrote:
> This small series aims to replace a one-element array with a
> flexible-array member in struct vfio_ccw_parent.
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [1].
> 
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/160
> Link: https://github.com/KSPP/linux/issues/297
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
> 
> Gustavo A. R. Silva (2):
>   vfio/ccw: Replace one-element array with flexible-array member
>   vfio/ccw: Use struct_size() helper
> 
>  drivers/s390/cio/vfio_ccw_drv.c     | 2 +-
>  drivers/s390/cio/vfio_ccw_private.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Fixed duplicate "the the" in patch #1 commit message and applied.

Thanks!

Re: [PATCH 0/2][next] vfio/ccw: Replace one-element array with flexible-array member

Posted by Matthew Rosato 2 years, 8 months ago

On 5/22/23 9:34 PM, Gustavo A. R. Silva wrote:
> Hi!
> 
> This small series aims to replace a one-element array with a
> flexible-array member in struct vfio_ccw_parent.
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [1].
> 
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/160
> Link: https://github.com/KSPP/linux/issues/297
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
> 
> Gustavo A. R. Silva (2):
>   vfio/ccw: Replace one-element array with flexible-array member
>   vfio/ccw: Use struct_size() helper
> 
>  drivers/s390/cio/vfio_ccw_drv.c     | 2 +-
>  drivers/s390/cio/vfio_ccw_private.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Hi Gustavo,

Thanks! For the series:

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>