drivers/base/regmap/regmap-irq.c | 5 ++--- drivers/gpio/gpio-104-dio-48e.c | 32 +++++++++++++++++++++++--------- include/linux/regmap.h | 3 +-- 3 files changed, 26 insertions(+), 14 deletions(-)
Changes in v2: - Pull out 104-dio-48e refactor to a precursor patch Remove the map parameter from the struct regmap_irq_chip callback handle_mask_sync() because it can be passed via the irq_drv_data parameter instead. The gpio-104-dio-48e driver is the only consumer of this callback and is thus updated accordingly. A couple pending patchsets also utilize handle_mask_sync() [0][1], so it'll be useful to merge the changes in this series first to avoid subsequent noise adjusting the dependent drivers. [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/ [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/ William Breathitt Gray (2): gpio: 104-dio-48e: Implement struct dio48e_gpio regmap-irq: Drop map from handle_mask_sync() parameters drivers/base/regmap/regmap-irq.c | 5 ++--- drivers/gpio/gpio-104-dio-48e.c | 32 +++++++++++++++++++++++--------- include/linux/regmap.h | 3 +-- 3 files changed, 26 insertions(+), 14 deletions(-) base-commit: 03810031c91dfe448cd116ee987d5dc4139006f4 -- 2.39.2
On Sun, Mar 19, 2023 at 05:02:00PM -0400, William Breathitt Gray wrote: > Changes in v2: > - Pull out 104-dio-48e refactor to a precursor patch > > Remove the map parameter from the struct regmap_irq_chip callback > handle_mask_sync() because it can be passed via the irq_drv_data > parameter instead. The gpio-104-dio-48e driver is the only consumer of > this callback and is thus updated accordingly. > > A couple pending patchsets also utilize handle_mask_sync() [0][1], so > it'll be useful to merge the changes in this series first to avoid > subsequent noise adjusting the dependent drivers. > > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/ > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/ Good idea and intention, but something went wrong with bisectability as pointed out by the build bot. As a last resort you would need to squash these two, but try first another possible patch series split. -- With Best Regards, Andy Shevchenko
On Mon, Mar 20, 2023 at 02:44:43PM +0200, Andy Shevchenko wrote: > On Sun, Mar 19, 2023 at 05:02:00PM -0400, William Breathitt Gray wrote: > > Changes in v2: > > - Pull out 104-dio-48e refactor to a precursor patch > > > > Remove the map parameter from the struct regmap_irq_chip callback > > handle_mask_sync() because it can be passed via the irq_drv_data > > parameter instead. The gpio-104-dio-48e driver is the only consumer of > > this callback and is thus updated accordingly. > > > > A couple pending patchsets also utilize handle_mask_sync() [0][1], so > > it'll be useful to merge the changes in this series first to avoid > > subsequent noise adjusting the dependent drivers. > > > > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/ > > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/ > > Good idea and intention, but something went wrong with bisectability as pointed > out by the build bot. As a last resort you would need to squash these two, but > try first another possible patch series split. > > -- > With Best Regards, > Andy Shevchenko I should have build tested each commit when I rebased rather than just the last. I'd rather avoid a squash so that these changes are distinct for the sake of a clear git history on the regmap API change; I'll submit a v3 soon with the minor changes needed. William Breathitt Gray
On Sun, Mar 19, 2023 at 05:18:53PM -0400, William Breathitt Gray wrote: > On Mon, Mar 20, 2023 at 02:44:43PM +0200, Andy Shevchenko wrote: > > On Sun, Mar 19, 2023 at 05:02:00PM -0400, William Breathitt Gray wrote: > > > Changes in v2: > > > - Pull out 104-dio-48e refactor to a precursor patch > > > > > > Remove the map parameter from the struct regmap_irq_chip callback > > > handle_mask_sync() because it can be passed via the irq_drv_data > > > parameter instead. The gpio-104-dio-48e driver is the only consumer of > > > this callback and is thus updated accordingly. > > > > > > A couple pending patchsets also utilize handle_mask_sync() [0][1], so > > > it'll be useful to merge the changes in this series first to avoid > > > subsequent noise adjusting the dependent drivers. > > > > > > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/ > > > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/ > > > > Good idea and intention, but something went wrong with bisectability as pointed > > out by the build bot. As a last resort you would need to squash these two, but > > try first another possible patch series split. > I should have build tested each commit when I rebased rather than just > the last. Right, that's what we call a "compile time bisectability". > I'd rather avoid a squash so that these changes are distinct > for the sake of a clear git history on the regmap API change; That's my point! I glad we are on the same page. > I'll submit a v3 soon with the minor changes needed. -- With Best Regards, Andy Shevchenko
On Sun, Mar 19, 2023 at 10:02 PM William Breathitt Gray <william.gray@linaro.org> wrote: > Changes in v2: > - Pull out 104-dio-48e refactor to a precursor patch > > Remove the map parameter from the struct regmap_irq_chip callback > handle_mask_sync() because it can be passed via the irq_drv_data > parameter instead. The gpio-104-dio-48e driver is the only consumer of > this callback and is thus updated accordingly. Looks reasonable: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
© 2016 - 2026 Red Hat, Inc.