[v3] dyndbg: let's use the module notifier callback

[PATCH v3 0/2] dyndbg: let's use the module notifier callback

Posted by Jason Baron 2 years, 6 months ago

Hi,

Jim Cromie hit a BUG() while toggling jump label branches in a module
before they were properly initialized. This isn't currently an issue,
but will be as part of his pending classmap series. Seems like we
should covert to using module callback notifier for dynamic debug
anyways to match other subsystems and remove core module code.
First patch is just a cleanup.

Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@xxxxxxxxx/

I've rebased this series onto modules-next tree. Although the first patch
is a cleanup entirely internal to dynamic debug I think it's a nice cleanup
to have as part of this series.

Thanks,

-Jason

v3:
-rebased to modules-next tree
-updated changelog as per Luis Chamberlain's suggestions

v2:
-Fix: error: field 'dyndbg_info' has incomplete type
 Reported-by: kernel test robot <lkp@intel.com>
 Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@intel.com/
-make ddebug_remove_module() static


Jason Baron (2):
  dyndbg: remove unused 'base' arg from __ddebug_add_module()
  dyndbg: use the module notifier callbacks

 include/linux/dynamic_debug.h | 13 ---------
 include/linux/module.h        |  4 +++
 kernel/module/internal.h      |  2 --
 kernel/module/main.c          | 30 ++++++---------------
 lib/dynamic_debug.c           | 51 ++++++++++++++++++++++++++++-------
 5 files changed, 53 insertions(+), 47 deletions(-)

-- 
2.17.1

Re: [PATCH v3 0/2] dyndbg: let's use the module notifier callback

Posted by Luis Chamberlain 2 years, 6 months ago

On Fri, Mar 03, 2023 at 11:50:54AM -0500, Jason Baron wrote:
> Hi,
> 
> Jim Cromie hit a BUG() while toggling jump label branches in a module
> before they were properly initialized. This isn't currently an issue,
> but will be as part of his pending classmap series. Seems like we
> should covert to using module callback notifier for dynamic debug
> anyways to match other subsystems and remove core module code.
> First patch is just a cleanup.
> 
> Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@xxxxxxxxx/
> 
> I've rebased this series onto modules-next tree. Although the first patch
> is a cleanup entirely internal to dynamic debug I think it's a nice cleanup
> to have as part of this series.

Thanks! Queued onto modules-next.

  Luis