[PATCH net-next 0/2] ethtool: add PLCA RS support

Piergiorgio Beruto posted 2 patches 2 years, 9 months ago
Makefile.am                  |   1 +
ethtool.c                    |  21 +++
netlink/extapi.h             |   6 +
netlink/plca.c               | 311 +++++++++++++++++++++++++++++++++++
netlink/settings.c           |  86 +++++++++-
uapi/linux/ethtool.h         | 104 ++++++++++--
uapi/linux/ethtool_netlink.h |  49 +++++-
uapi/linux/genetlink.h       |   6 +-
uapi/linux/if_link.h         |  23 ++-
uapi/linux/netlink.h         |  41 +++--
uapi/linux/rtnetlink.h       |   8 +-
11 files changed, 616 insertions(+), 40 deletions(-)
create mode 100644 netlink/plca.c
[PATCH net-next 0/2] ethtool: add PLCA RS support
Posted by Piergiorgio Beruto 2 years, 9 months ago
This patchset is related to the proposed "add PLCA RS support and onsemi
NCN26000" patchset on the kernel. It adds userland support for
getting/setting the configuration of the Physical Layer Collision
Avoidance (PLCA) Reconciliation Sublayer (RS) defined in the IEEE 802.3
specifications, amended by IEEE802.3cg-2019.

Piergiorgio Beruto (2):
  Update UAPI files
  Add support for IEEE 802.3cg-2019 Clause 148 - PLCA RS

 Makefile.am                  |   1 +
 ethtool.c                    |  21 +++
 netlink/extapi.h             |   6 +
 netlink/plca.c               | 311 +++++++++++++++++++++++++++++++++++
 netlink/settings.c           |  86 +++++++++-
 uapi/linux/ethtool.h         | 104 ++++++++++--
 uapi/linux/ethtool_netlink.h |  49 +++++-
 uapi/linux/genetlink.h       |   6 +-
 uapi/linux/if_link.h         |  23 ++-
 uapi/linux/netlink.h         |  41 +++--
 uapi/linux/rtnetlink.h       |   8 +-
 11 files changed, 616 insertions(+), 40 deletions(-)
 create mode 100644 netlink/plca.c

-- 
2.35.1
Re: [PATCH net-next 0/2] ethtool: add PLCA RS support
Posted by Jakub Kicinski 2 years, 9 months ago
On Sun, 4 Dec 2022 03:37:57 +0100 Piergiorgio Beruto wrote:
> This patchset is related to the proposed "add PLCA RS support and onsemi
> NCN26000" patchset on the kernel. It adds userland support for
> getting/setting the configuration of the Physical Layer Collision
> Avoidance (PLCA) Reconciliation Sublayer (RS) defined in the IEEE 802.3
> specifications, amended by IEEE802.3cg-2019.

nit: for the user space patches use the tool name in the subject tag
[PATCH ethtool-next], I bet quite a few people looked at your set
expecting kernel changes ;)
Re: [PATCH net-next 0/2] ethtool: add PLCA RS support
Posted by Jakub Kicinski 2 years, 9 months ago
On Mon, 5 Dec 2022 18:05:27 -0800 Jakub Kicinski wrote:
> On Sun, 4 Dec 2022 03:37:57 +0100 Piergiorgio Beruto wrote:
> > This patchset is related to the proposed "add PLCA RS support and onsemi
> > NCN26000" patchset on the kernel. It adds userland support for
> > getting/setting the configuration of the Physical Layer Collision
> > Avoidance (PLCA) Reconciliation Sublayer (RS) defined in the IEEE 802.3
> > specifications, amended by IEEE802.3cg-2019.  
> 
> nit: for the user space patches use the tool name in the subject tag
> [PATCH ethtool-next], I bet quite a few people looked at your set
> expecting kernel changes ;)

... which you already figured out / was told. Is a very bad day 
for my ability to spot next postings of the same set it seems :S
Re: [PATCH net-next 0/2] ethtool: add PLCA RS support
Posted by Piergiorgio Beruto 2 years, 9 months ago
On Mon, Dec 05, 2022 at 08:11:52PM -0800, Jakub Kicinski wrote:
> On Mon, 5 Dec 2022 18:05:27 -0800 Jakub Kicinski wrote:
> > On Sun, 4 Dec 2022 03:37:57 +0100 Piergiorgio Beruto wrote:
> > > This patchset is related to the proposed "add PLCA RS support and onsemi
> > > NCN26000" patchset on the kernel. It adds userland support for
> > > getting/setting the configuration of the Physical Layer Collision
> > > Avoidance (PLCA) Reconciliation Sublayer (RS) defined in the IEEE 802.3
> > > specifications, amended by IEEE802.3cg-2019.  
> > 
> > nit: for the user space patches use the tool name in the subject tag
> > [PATCH ethtool-next], I bet quite a few people looked at your set
> > expecting kernel changes ;)
> 
> ... which you already figured out / was told. Is a very bad day 
> for my ability to spot next postings of the same set it seems :S
Thanks Jakub, don't worry, I am still learning the process, so better
one more feedback than none!

BTW, I've just updated the patchset to include all the feedback I did
receiver so far. Hopefully this one is good :-)

Kind Regards,
Piergiorgio