[PATCH 3/4] elevator: repalce "len+name" with "name+len" in elv_iosched_show

Jinlong Chen posted 4 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH 3/4] elevator: repalce "len+name" with "name+len" in elv_iosched_show
Posted by Jinlong Chen 2 years, 9 months ago
The "pointer + offset" pattern is more resonable.

Signed-off-by: Jinlong Chen <nickyc975@zju.edu.cn>
---
 block/elevator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/elevator.c b/block/elevator.c
index ffa750976d25..93dbaa560b67 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -783,7 +783,7 @@ ssize_t elv_iosched_show(struct request_queue *q, char *name)
 	}
 	spin_unlock(&elv_list_lock);
 
-	len += sprintf(len+name, "\n");
+	len += sprintf(name+len, "\n");
 	return len;
 }
 
-- 
2.34.1
Re: [PATCH 3/4] elevator: repalce "len+name" with "name+len" in elv_iosched_show
Posted by Christoph Hellwig 2 years, 9 months ago
On Fri, Nov 25, 2022 at 11:53:13PM +0800, Jinlong Chen wrote:
> The "pointer + offset" pattern is more resonable.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>