[PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging RT_TRACE

Philipp Hortmann posted 6 patches 3 years, 6 months ago
.../rtl8192e/rtl8192e/r8190P_rtl8256.c        |   6 -
.../staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c |   2 -
.../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 161 +----------------
.../rtl8192e/rtl8192e/r8192E_firmware.c       |   7 -
.../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 132 --------------
drivers/staging/rtl8192e/rtl8192e/rtl_cam.c   |  16 --
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 165 ------------------
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c   |   2 -
drivers/staging/rtl8192e/rtl8192e/rtl_pm.c    |   1 -
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c    |  34 ----
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   8 -
drivers/staging/rtl8192e/rtl819x_BAProc.c     |   5 -
drivers/staging/rtl8192e/rtllib_debug.h       |   6 -
drivers/staging/rtl8192e/rtllib_softmac.c     |   8 -
drivers/staging/rtl8192e/rtllib_softmac_wx.c  |   6 -
15 files changed, 1 insertion(+), 558 deletions(-)
[PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging RT_TRACE
Posted by Philipp Hortmann 3 years, 6 months ago
Remove "Unnecessary ftrace-like logging" as requested by checkpatch. To
keep the logging would make future patches for fixing CamelCase larger.

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

Philipp Hortmann (6):
  staging: rtl8192e: Remove ftrace-like logging in r8192E_firmware.c,
    ...
  staging: rtl8192e: Remove ftrace-like logging in r8192E_dev.c
  staging: rtl8192e: Remove ftrace-like logging in r8192E_phy.c
  staging: rtl8192e: Remove ftrace-like logging in rtl_dm.c
  staging: rtl8192e: Remove ftrace-like logging in rtl_ps.c
  staging: rtl8192e: Remove ftrace-like logging in rtl819x_BAProc.c, ...

 .../rtl8192e/rtl8192e/r8190P_rtl8256.c        |   6 -
 .../staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c |   2 -
 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 161 +----------------
 .../rtl8192e/rtl8192e/r8192E_firmware.c       |   7 -
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 132 --------------
 drivers/staging/rtl8192e/rtl8192e/rtl_cam.c   |  16 --
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 165 ------------------
 drivers/staging/rtl8192e/rtl8192e/rtl_pci.c   |   2 -
 drivers/staging/rtl8192e/rtl8192e/rtl_pm.c    |   1 -
 drivers/staging/rtl8192e/rtl8192e/rtl_ps.c    |  34 ----
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   8 -
 drivers/staging/rtl8192e/rtl819x_BAProc.c     |   5 -
 drivers/staging/rtl8192e/rtllib_debug.h       |   6 -
 drivers/staging/rtl8192e/rtllib_softmac.c     |   8 -
 drivers/staging/rtl8192e/rtllib_softmac_wx.c  |   6 -
 15 files changed, 1 insertion(+), 558 deletions(-)

-- 
2.37.3
Re: [PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging RT_TRACE
Posted by Dan Carpenter 3 years, 6 months ago
On Sat, Sep 17, 2022 at 06:24:53AM +0200, Philipp Hortmann wrote:
> Remove "Unnecessary ftrace-like logging" as requested by checkpatch. To
> keep the logging would make future patches for fixing CamelCase larger.
> 
> Tested with rtl8192e
> Transferred this patch over wlan connection of rtl8192e
> 

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

When I'm reviewing a mass delete change like this, the typical bug that
I'm looking for is deleting extra lines by mistake.  So I go through it
line by line and make sure nothing extra was deleted.  It's not
complicated but it just takes a while to check.

This patchset will introduce some checkpatch warnings about extra
curly braces but I actually prefer if those are fixed in a separate
patch.  It makes these easier to review.  If you were just deleting
one RT_TRACE() call then doing it together is the correct thing but when
it's a mass delete I prefer the curly braces changes done as a separate
thing.

regards,
dan carpenter