[PATCH 0/4] Make irq_chip immutable for ISA drivers

William Breathitt Gray posted 4 patches 3 years, 7 months ago
drivers/gpio/gpio-104-dio-48e.c | 10 +++++++---
drivers/gpio/gpio-104-idi-48.c  | 10 +++++++---
drivers/gpio/gpio-104-idio-16.c | 18 +++++++++++-------
drivers/gpio/gpio-ws16c48.c     | 10 +++++++---
4 files changed, 32 insertions(+), 16 deletions(-)
[PATCH 0/4] Make irq_chip immutable for ISA drivers
Posted by William Breathitt Gray 3 years, 7 months ago
Kernel warns about mutable irq_chips in ISA drivers:

    "not an immutable chip, please consider fixing!"

Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the
new helper functions, and call the appropriate gpiolib functions.

William Breathitt Gray (4):
  gpio: 104-dio-48e: Make irq_chip immutable
  gpio: 104-idi-48: Make irq_chip immutable
  gpio: 104-idio-16: Make irq_chip immutable
  gpio: ws16c48: Make irq_chip immutable

 drivers/gpio/gpio-104-dio-48e.c | 10 +++++++---
 drivers/gpio/gpio-104-idi-48.c  | 10 +++++++---
 drivers/gpio/gpio-104-idio-16.c | 18 +++++++++++-------
 drivers/gpio/gpio-ws16c48.c     | 10 +++++++---
 4 files changed, 32 insertions(+), 16 deletions(-)


base-commit: 6ae8e1d0d5e5de922315830aea975c63e8c70b2f
-- 
2.37.2
Re: [PATCH 0/4] Make irq_chip immutable for ISA drivers
Posted by Bartosz Golaszewski 3 years, 7 months ago
On Fri, Sep 2, 2022 at 11:40 PM William Breathitt Gray
<william.gray@linaro.org> wrote:
>
> Kernel warns about mutable irq_chips in ISA drivers:
>
>     "not an immutable chip, please consider fixing!"
>
> Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the
> new helper functions, and call the appropriate gpiolib functions.
>
> William Breathitt Gray (4):
>   gpio: 104-dio-48e: Make irq_chip immutable
>   gpio: 104-idi-48: Make irq_chip immutable
>   gpio: 104-idio-16: Make irq_chip immutable
>   gpio: ws16c48: Make irq_chip immutable
>
>  drivers/gpio/gpio-104-dio-48e.c | 10 +++++++---
>  drivers/gpio/gpio-104-idi-48.c  | 10 +++++++---
>  drivers/gpio/gpio-104-idio-16.c | 18 +++++++++++-------
>  drivers/gpio/gpio-ws16c48.c     | 10 +++++++---
>  4 files changed, 32 insertions(+), 16 deletions(-)
>
>
> base-commit: 6ae8e1d0d5e5de922315830aea975c63e8c70b2f
> --
> 2.37.2
>

Queued for fixes, thanks!

Bart