because this function is not used.

Signed-off-by: Nam Cao <namcaov@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_odm.c    | 16 ----------------
 drivers/staging/rtl8723bs/include/rtw_odm.h |  1 -
 2 files changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl8723bs/core/rtw_odm.c
index f6b73a2a0270..abb111752169 100644
--- a/drivers/staging/rtl8723bs/core/rtw_odm.c
+++ b/drivers/staging/rtl8723bs/core/rtw_odm.c
@@ -90,22 +90,6 @@ static const char * const odm_dbg_level_str[] = {
 
 #define RTW_ODM_DBG_LEVEL_NUM 6
 
-void rtw_odm_dbg_comp_msg(struct adapter *adapter)
-{
-	u64 dbg_comp;
-	int i;
-
-	rtw_hal_get_def_var(adapter, HW_DEF_ODM_DBG_FLAG, &dbg_comp);
-	netdev_dbg(adapter->pnetdev, "odm.DebugComponents = 0x%016llx\n",
-		   dbg_comp);
-	for (i = 0; i < RTW_ODM_COMP_MAX; i++) {
-		if (odm_comp_str[i])
-			netdev_dbg(adapter->pnetdev, "%cBIT%-2d %s\n",
-				   (BIT0 << i) & dbg_comp ? '+' : ' ', i,
-				   odm_comp_str[i]);
-	}
-}
-
 inline void rtw_odm_dbg_comp_set(struct adapter *adapter, u64 comps)
 {
 	rtw_hal_set_def_var(adapter, HW_DEF_ODM_DBG_FLAG, &comps);
diff --git a/drivers/staging/rtl8723bs/include/rtw_odm.h b/drivers/staging/rtl8723bs/include/rtw_odm.h
index 94fc68a5c424..27e8240284b4 100644
--- a/drivers/staging/rtl8723bs/include/rtw_odm.h
+++ b/drivers/staging/rtl8723bs/include/rtw_odm.h
@@ -13,7 +13,6 @@
 * This file provides utilities/wrappers for rtw driver to use ODM
 */
 
-void rtw_odm_dbg_comp_msg(struct adapter *adapter);
 void rtw_odm_dbg_comp_set(struct adapter *adapter, u64 comps);
 void rtw_odm_dbg_level_msg(void *sel, struct adapter *adapter);
 void rtw_odm_dbg_level_set(struct adapter *adapter, u32 level);
-- 
2.25.1

On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> because this function is not used.
> 
> Signed-off-by: Nam Cao <namcaov@gmail.com>

This patch is fine, but in the future can you please treat the subject
as separate from the commit message.  "because it is not used" is a
sucky commit message.  What is not used?  What are you doing to it?  It
doesn't start with a capital letter.

Here is how your email looks like on lore.

https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com/

Try to find the subject in the middle of the block of text.  People are
often only going to read the body of the email.

[PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()

The rtw_odm_dbg_comp_msg() function is not used.  Delete it.

Signed-off-by:

regards,
dan carpenter

Thank you so much for letting me know. I will try to make it more readable in
the future.

Best regards,
Nam

On Mon, Aug 22, 2022 at 9:34 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> > because this function is not used.
> >
> > Signed-off-by: Nam Cao <namcaov@gmail.com>
>
> This patch is fine, but in the future can you please treat the subject
> as separate from the commit message.  "because it is not used" is a
> sucky commit message.  What is not used?  What are you doing to it?  It
> doesn't start with a capital letter.
>
> Here is how your email looks like on lore.
>
> https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com/
>
> Try to find the subject in the middle of the block of text.  People are
> often only going to read the body of the email.
>
> [PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()
>
> The rtw_odm_dbg_comp_msg() function is not used.  Delete it.
>
> Signed-off-by:
>
> regards,
> dan carpenter
>