remove some dead code

[PATCH v2 0/8] remove some dead code

Posted by Nam Cao 3 years, 7 months ago

Remove some unused functions and variables.

Change in v2: add a new patch to fix kernel test robot's warning
about unused variable.

Nam Cao (8):
  staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg
  staging: rtl8723bs: remove function rtw_get_ch_setting_union
  staging: rtl8723bs: remove function rtw_odm_ability_set
  staging: rtl8723bs: remove function GetFractionValueFromString
  staging: rtl8723bs: remove function IsCommentString
  staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg
  staging: rtl8723bs: remove function rtw_odm_dbg_comp_set
  staging: rtl8723bs: remove static const variable odm_comp_str

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 21 -----
 drivers/staging/rtl8723bs/core/rtw_odm.c      | 79 -------------------
 drivers/staging/rtl8723bs/hal/hal_com.c       | 55 -------------
 drivers/staging/rtl8723bs/include/hal_com.h   |  5 --
 .../staging/rtl8723bs/include/rtw_mlme_ext.h  |  1 -
 drivers/staging/rtl8723bs/include/rtw_odm.h   |  4 -
 6 files changed, 165 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/8] remove some dead code

Posted by Hans de Goede 3 years, 7 months ago

Hi,

On 8/19/22 15:49, Nam Cao wrote:
> Remove some unused functions and variables.
> 
> Change in v2: add a new patch to fix kernel test robot's warning
> about unused variable.
> 
> Nam Cao (8):
>   staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg
>   staging: rtl8723bs: remove function rtw_get_ch_setting_union
>   staging: rtl8723bs: remove function rtw_odm_ability_set
>   staging: rtl8723bs: remove function GetFractionValueFromString
>   staging: rtl8723bs: remove function IsCommentString
>   staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg
>   staging: rtl8723bs: remove function rtw_odm_dbg_comp_set
>   staging: rtl8723bs: remove static const variable odm_comp_str
> 
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 21 -----
>  drivers/staging/rtl8723bs/core/rtw_odm.c      | 79 -------------------
>  drivers/staging/rtl8723bs/hal/hal_com.c       | 55 -------------
>  drivers/staging/rtl8723bs/include/hal_com.h   |  5 --
>  .../staging/rtl8723bs/include/rtw_mlme_ext.h  |  1 -
>  drivers/staging/rtl8723bs/include/rtw_odm.h   |  4 -
>  6 files changed, 165 deletions(-)

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans