staging: r8188eu: cleanup some metadata issues

[PATCH v2 0/4] staging: r8188eu: cleanup some metadata issues

Posted by Grzegorz Szymaszek 3 years, 8 months ago

This patchset tries to improve the r8188eu driver metadata. Some
hardcoded values are replaced with proper macros, some unnecessary
macros are removed.

Changes for v2:
- added a cover letter and a base tree reference;
- added Philipp Hortmann's Tested-by;
- replaced the second and the third patch with different ones, per Greg
  Kroah-Hartman's suggestions to make better use of existing kernel
  macros and remove unnecessary ones.

Grzegorz Szymaszek (4):
  staging: r8188eu: set firmware path in a macro
  staging: r8188eu: use KBUILD_MODNAME instead of a string constant
  staging: r8188eu: drop the DRV_NAME macro
  staging: r8188eu: drop the DRIVERVERSION macro

 drivers/staging/r8188eu/core/rtw_fw.c       | 2 +-
 drivers/staging/r8188eu/include/drv_types.h | 4 +---
 drivers/staging/r8188eu/os_dep/os_intfs.c   | 3 +--
 drivers/staging/r8188eu/os_dep/usb_intf.c   | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)


base-commit: 9de1f9c8ca5100a02a2e271bdbde36202e251b4b
prerequisite-patch-id: 79964bd0bcd260f1df53830a81e009c34993ee6f
-- 
2.35.1

Re: [PATCH v2 0/4] staging: r8188eu: cleanup some metadata issues

Posted by Philipp Hortmann 3 years, 8 months ago

On 8/5/22 18:27, Grzegorz Szymaszek wrote:
> This patchset tries to improve the r8188eu driver metadata. Some
> hardcoded values are replaced with proper macros, some unnecessary
> macros are removed.
> 
> Changes for v2:
> - added a cover letter and a base tree reference;
> - added Philipp Hortmann's Tested-by;
> - replaced the second and the third patch with different ones, per Greg
>    Kroah-Hartman's suggestions to make better use of existing kernel
>    macros and remove unnecessary ones.
> 
> Grzegorz Szymaszek (4):
>    staging: r8188eu: set firmware path in a macro
>    staging: r8188eu: use KBUILD_MODNAME instead of a string constant
>    staging: r8188eu: drop the DRV_NAME macro
>    staging: r8188eu: drop the DRIVERVERSION macro
> 
>   drivers/staging/r8188eu/core/rtw_fw.c       | 2 +-
>   drivers/staging/r8188eu/include/drv_types.h | 4 +---
>   drivers/staging/r8188eu/os_dep/os_intfs.c   | 3 +--
>   drivers/staging/r8188eu/os_dep/usb_intf.c   | 2 +-
>   4 files changed, 4 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 9de1f9c8ca5100a02a2e271bdbde36202e251b4b
> prerequisite-patch-id: 79964bd0bcd260f1df53830a81e009c34993ee6f


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150