[PATCH net-next v4 0/2] net: hinic: fix bugs about dev_get_stats

Qiao Ma posted 2 patches 3 years, 9 months ago
Only 1 patches received!
drivers/net/ethernet/huawei/hinic/hinic_dev.h  |  3 --
drivers/net/ethernet/huawei/hinic/hinic_main.c | 61 +++++++-------------------
drivers/net/ethernet/huawei/hinic/hinic_rx.c   |  2 -
drivers/net/ethernet/huawei/hinic/hinic_tx.c   |  2 -
4 files changed, 16 insertions(+), 52 deletions(-)
[PATCH net-next v4 0/2] net: hinic: fix bugs about dev_get_stats
Posted by Qiao Ma 3 years, 9 months ago
These patches fixes 2 bugs of hinic driver:
- fix bug that ethtool get wrong stats because of hinic_{txq|rxq}_clean_stats() is called
- avoid kernel hung in hinic_get_stats64() 

See every patch for more information. 

Changes in v4:
- removed meaningless u64_stats_sync protection in hinic_{txq|rxq}_get_stats
- merged the third patch in v2 into first one

Changes in v3:
- fixes a compile warning reported by kernel test robot <lkp@intel.com>

Changes in v2:
- fixes another 2 bugs. (v1 is a single patch, see: https://lore.kernel.org/all/07736c2b7019b6883076a06129e06e8f7c5f7154.1656487154.git.mqaio@linux.alibaba.com/).
- to fix extra bugs, hinic_dev.tx_stats/rx_stats is removed, so there is no need to use spinlock or semaphore now. 

Qiao Ma (2):
  net: hinic: fix bug that ethtool get wrong stats
  net: hinic: avoid kernel hung in hinic_get_stats64()

 drivers/net/ethernet/huawei/hinic/hinic_dev.h  |  3 --
 drivers/net/ethernet/huawei/hinic/hinic_main.c | 61 +++++++-------------------
 drivers/net/ethernet/huawei/hinic/hinic_rx.c   |  2 -
 drivers/net/ethernet/huawei/hinic/hinic_tx.c   |  2 -
 4 files changed, 16 insertions(+), 52 deletions(-)

-- 
1.8.3.1
Re: [PATCH net-next v4 0/2] net: hinic: fix bugs about dev_get_stats
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 9 months ago
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue,  5 Jul 2022 19:22:21 +0800 you wrote:
> These patches fixes 2 bugs of hinic driver:
> - fix bug that ethtool get wrong stats because of hinic_{txq|rxq}_clean_stats() is called
> - avoid kernel hung in hinic_get_stats64()
> 
> See every patch for more information.
> 
> Changes in v4:
> - removed meaningless u64_stats_sync protection in hinic_{txq|rxq}_get_stats
> - merged the third patch in v2 into first one
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/2] net: hinic: fix bug that ethtool get wrong stats
    https://git.kernel.org/netdev/net-next/c/67dffd3db985
  - [net-next,v4,2/2] net: hinic: avoid kernel hung in hinic_get_stats64()
    https://git.kernel.org/netdev/net-next/c/98f9fcdee35a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html