get rid of useless header file

[PATCH 0/2] get rid of useless header file

Nam Cao posted 2 patches 3 years, 10 months ago

Download series mbox

drivers/staging/r8188eu/core/rtw_recv.c       |  2 +-
drivers/staging/r8188eu/core/rtw_xmit.c       |  6 +++---
drivers/staging/r8188eu/hal/rtl8188eu_recv.c  |  2 +-
drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
.../staging/r8188eu/include/osdep_service.h   |  1 -
drivers/staging/r8188eu/os_dep/xmit_linux.c   |  2 +-
6 files changed, 6 insertions(+), 26 deletions(-)
delete mode 100644 drivers/staging/r8188eu/include/basic_types.h

Expand all Fold all

[PATCH 0/2] get rid of useless header file

Posted by Nam Cao 3 years, 10 months ago

The stuffs in basic_types.h are either not used, or already defined in
the kernel. Get rid of it.

Nam Cao (2):
  staging: r8188eu: replace N_BYTE_ALIGMENT with ALIGN
  staging: r8188eu: remove basic_types.h

 drivers/staging/r8188eu/core/rtw_recv.c       |  2 +-
 drivers/staging/r8188eu/core/rtw_xmit.c       |  6 +++---
 drivers/staging/r8188eu/hal/rtl8188eu_recv.c  |  2 +-
 drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
 .../staging/r8188eu/include/osdep_service.h   |  1 -
 drivers/staging/r8188eu/os_dep/xmit_linux.c   |  2 +-
 6 files changed, 6 insertions(+), 26 deletions(-)
 delete mode 100644 drivers/staging/r8188eu/include/basic_types.h

-- 
2.25.1

Re: [PATCH 0/2] get rid of useless header file

Posted by Larry Finger 3 years, 10 months ago

On 6/20/22 12:19, Nam Cao wrote:
> The stuffs in basic_types.h are either not used, or already defined in
> the kernel. Get rid of it.
> 
> Nam Cao (2):
>    staging: r8188eu: replace N_BYTE_ALIGMENT with ALIGN
>    staging: r8188eu: remove basic_types.h
> 
>   drivers/staging/r8188eu/core/rtw_recv.c       |  2 +-
>   drivers/staging/r8188eu/core/rtw_xmit.c       |  6 +++---
>   drivers/staging/r8188eu/hal/rtl8188eu_recv.c  |  2 +-
>   drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
>   .../staging/r8188eu/include/osdep_service.h   |  1 -
>   drivers/staging/r8188eu/os_dep/xmit_linux.c   |  2 +-
>   6 files changed, 6 insertions(+), 26 deletions(-)
>   delete mode 100644 drivers/staging/r8188eu/include/basic_types.h
> 

For future patch sets, please include the "staging: r8188eu:" part of the 
subject of the cover letter. It makes it easier to sort out the rest of the 
patches; however,it is not necessary to resubmit this one.

The two patchesw are fine.

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks,

Larry