[v4] memblock tests: update style of comments

[PATCH v4 0/5] memblock tests: update style of comments

Posted by Rebecca Mckeever 4 years ago

These patches update the style of comments for memblock_add_*(),
memblock_reserve_*(), memblock_remove_*(), and memblock_free_*()
functions to match the style of comments in tests/alloc_*.c and
remove extra spaces in those comments to conform to Linux kernel
coding style. This completes an item from the TODO list.

Rebecca Mckeever (5):
  memblock tests: update style of comments for memblock_add_*()
    functions
  memblock tests: update style of comments for memblock_reserve_*()
    functions
  memblock tests: update style of comments for memblock_remove_*()
    functions
  memblock tests: update style of comments for memblock_free_*()
    functions
  memblock tests: remove completed TODO item

 tools/testing/memblock/TODO              |   3 -
 tools/testing/memblock/tests/basic_api.c | 392 ++++++++++++++++-------
 2 files changed, 278 insertions(+), 117 deletions(-)

---
Changes

v1 -> v2
PATCH 1: 
  Add a comma
  Move separator outside block name
Squash white space edit into PATCH 2
PATCH 1 and PATCH 2: add a colon before memory block visuals
Add PATCH 3: update style of comments for memblock_remove_*() functions
Add PATCH 4: update style of comments for memblock_free_*() functions

v2 -> v3
Add PATCH 5: remove completed TODO item
Add changes summary

v3 -> v4
PATCH 1 and PATCH 2: add Reviewed-by tags
PATCH 1 through PATCH 4:
  Correct grammar
  Replace references to first or second (block/region) with r1 or r2
  Add references to r1 or r2 as needed for clarity
---

-- 
2.32.0

Re: [PATCH v4 0/5] memblock tests: update style of comments

Posted by David Hildenbrand 4 years ago

On 01.05.22 00:49, Rebecca Mckeever wrote:
> These patches update the style of comments for memblock_add_*(),
> memblock_reserve_*(), memblock_remove_*(), and memblock_free_*()
> functions to match the style of comments in tests/alloc_*.c and
> remove extra spaces in those comments to conform to Linux kernel
> coding style. This completes an item from the TODO list.
> 
> Rebecca Mckeever (5):
>   memblock tests: update style of comments for memblock_add_*()
>     functions
>   memblock tests: update style of comments for memblock_reserve_*()
>     functions
>   memblock tests: update style of comments for memblock_remove_*()
>     functions
>   memblock tests: update style of comments for memblock_free_*()
>     functions
>   memblock tests: remove completed TODO item
> 
>  tools/testing/memblock/TODO              |   3 -
>  tools/testing/memblock/tests/basic_api.c | 392 ++++++++++++++++-------
>  2 files changed, 278 insertions(+), 117 deletions(-)
> 
> ---

Series

Reviewed-by: David Hildenbrand <david@redhat.com>

Thanks!

-- 
Thanks,

David / dhildenb

Re: [PATCH v4 0/5] memblock tests: update style of comments

Posted by Mike Rapoport 4 years ago

On Sat, Apr 30, 2022 at 05:49:35PM -0500, Rebecca Mckeever wrote:
> These patches update the style of comments for memblock_add_*(),
> memblock_reserve_*(), memblock_remove_*(), and memblock_free_*()
> functions to match the style of comments in tests/alloc_*.c and
> remove extra spaces in those comments to conform to Linux kernel
> coding style. This completes an item from the TODO list.
> 
> Rebecca Mckeever (5):
>   memblock tests: update style of comments for memblock_add_*()
>     functions
>   memblock tests: update style of comments for memblock_reserve_*()
>     functions
>   memblock tests: update style of comments for memblock_remove_*()
>     functions
>   memblock tests: update style of comments for memblock_free_*()
>     functions
>   memblock tests: remove completed TODO item
> 
>  tools/testing/memblock/TODO              |   3 -
>  tools/testing/memblock/tests/basic_api.c | 392 ++++++++++++++++-------
>  2 files changed, 278 insertions(+), 117 deletions(-)

Applied, thanks!
 
-- 
Sincerely yours,
Mike.