[PATCH v2 0/2] staging: rtl8192u: cleanup of ternary and if else statements

Rebecca Mckeever posted 2 patches 4 years, 1 month ago
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c   |  4 +++-
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 +++++--------
2 files changed, 8 insertions(+), 9 deletions(-)
[PATCH v2 0/2] staging: rtl8192u: cleanup of ternary and if else statements
Posted by Rebecca Mckeever 4 years, 1 month ago
These patches replace ternary and if else statements with
more readable statements. Found with minmax coccinelle script.

---
v1 -> v2:
* Patch 1: "staging: rtl8192u: replace ternary statement with if and
* assignment"
  * replaced max macro with an if statement followed by an assignment

* Patch 2: "staging: rtl8192u: use min_t/max_t macros instead of if
* else"
  * changed the type argument in min_t and max_t from u8 to u32
---

Rebecca Mckeever (2):
  staging: rtl8192u: replace ternary statement with if and assignment
  staging: rtl8192u: use min_t/max_t macros instead of if else

 drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c   |  4 +++-
 drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 +++++--------
 2 files changed, 8 insertions(+), 9 deletions(-)

-- 
2.32.0
Re: [PATCH v2 0/2] staging: rtl8192u: cleanup of ternary and if else statements
Posted by Dan Carpenter 4 years, 1 month ago
On Thu, Apr 07, 2022 at 08:12:49PM -0500, Rebecca Mckeever wrote:
> These patches replace ternary and if else statements with
> more readable statements. Found with minmax coccinelle script.
> 
> ---
> v1 -> v2:
> * Patch 1: "staging: rtl8192u: replace ternary statement with if and
> * assignment"
>   * replaced max macro with an if statement followed by an assignment
> 
> * Patch 2: "staging: rtl8192u: use min_t/max_t macros instead of if
> * else"
>   * changed the type argument in min_t and max_t from u8 to u32
> ---

Looks great.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter