[PATCH v2 0/3] rlt8723bs cleanup

Sevinj Aghayeva posted 3 patches 4 years, 2 months ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 167 ++++++++----------
1 file changed, 70 insertions(+), 97 deletions(-)
[PATCH v2 0/3] rlt8723bs cleanup
Posted by Sevinj Aghayeva 4 years, 2 months ago
These patches fix three categories of checkpatch warnings (redundant
braces, redundant else branches after return/break, and constant
placements on tests) in file rtw_mlme_ext.c, which is part of the
rtl8723bs driver. False positives, such as

if (foo) {
	/* TODO: ... */
}

were not altered.

---
v1 -> v2: Removing a redundant else branch left a variable declaration
mixed with code, which was caught by the kernel test bot. Move the
declaration to the beginning of a function.
---

Sevinj Aghayeva (3):
  staging: rtl8723bs: remove redundant braces in if statements
  staging: rtl8723bs: place constants on the right side of tests
  staging: rtl8723bs: remove redundant else branches

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 167 ++++++++----------
 1 file changed, 70 insertions(+), 97 deletions(-)

-- 
2.25.1
Re: [PATCH v2 0/3] rlt8723bs cleanup
Posted by Sevinj Aghayeva 4 years, 2 months ago
Oops, apologies for the noise!

I tried to send v2 of the patchset but I had older versions of the
patches in /tmp and since I specified /tmp/*.patch to git send-email
per tutorial, it ended up sending all of the files there. I will send
a v3 ASAP and update the tutorial to prevent others from repeating the
same mistake!

On Fri, Apr 1, 2022 at 3:07 PM Sevinj Aghayeva
<sevinj.aghayeva@gmail.com> wrote:
>
> These patches fix three categories of checkpatch warnings (redundant
> braces, redundant else branches after return/break, and constant
> placements on tests) in file rtw_mlme_ext.c, which is part of the
> rtl8723bs driver. False positives, such as
>
> if (foo) {
>         /* TODO: ... */
> }
>
> were not altered.
>
> ---
> v1 -> v2: Removing a redundant else branch left a variable declaration
> mixed with code, which was caught by the kernel test bot. Move the
> declaration to the beginning of a function.
> ---
>
> Sevinj Aghayeva (3):
>   staging: rtl8723bs: remove redundant braces in if statements
>   staging: rtl8723bs: place constants on the right side of tests
>   staging: rtl8723bs: remove redundant else branches
>
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 167 ++++++++----------
>  1 file changed, 70 insertions(+), 97 deletions(-)
>
> --
> 2.25.1
>


-- 

Sevinj.Aghayeva