There were 2 patches in v1 that were flagged by the 0day robot for
strncpy off-by-1 warnings:

  tracing: Remove size restriction on hist trigger cmd error logging
  tracing: Remove size restriction on synthetic event cmd error logging

  warning: 'strncpy' output truncated before terminating nul copying
  as many bytes from a string as its length [-Wstringop-truncation]

This v2 patchset consists of just those two patches with the fix for
those warnings.

Tom

v1 text below


Hi Steve,

This is an assorted bunch of bugfixes addressing a bugzilla bug,
smatch warnings, and related things I found while fixing those.  In
particular, when looking at the bugzilla bug,
https://bugzilla.kernel.org/show_bug.cgi?id=215513, I noticed that the
err_log output looked truncated and looking further into it found that
it was, because the hist trigger command was very long, exceeding the
256 character limit.

Obviously that's too short, and the final 3 patches remove that
limitation.

Tom

The following changes since commit ca965f23256b350ebd94b3dc1a319f28e8267f5f:

  tracing: Remove size restriction on tracing_log_err cmd strings (2022-01-27 15:38:28 -0600)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/misc-bugfixes-v2

Tom Zanussi (2):
  tracing: Remove size restriction on hist trigger cmd error logging
  tracing: Remove size restriction on synthetic event cmd error logging

 kernel/trace/trace_events_hist.c  | 30 +++++++++++++++++++++++-------
 kernel/trace/trace_events_synth.c | 17 ++++++++++++++---
 2 files changed, 37 insertions(+), 10 deletions(-)

-- 
2.17.1

On Fri, 28 Jan 2022 14:08:25 -0600
Tom Zanussi <zanussi@kernel.org> wrote:

> There were 2 patches in v1 that were flagged by the 0day robot for
> strncpy off-by-1 warnings:
> 
>   tracing: Remove size restriction on hist trigger cmd error logging
>   tracing: Remove size restriction on synthetic event cmd error logging
> 
>   warning: 'strncpy' output truncated before terminating nul copying
>   as many bytes from a string as its length [-Wstringop-truncation]
> 
> This v2 patchset consists of just those two patches with the fix for
> those warnings.


So this just replaces the last two patches you sent previously?

Probably would have been better to send all three (since the other 4
already made it into mainline).

But if "tracing: Remove size restriction on tracing_log_err cmd strings" is
OK:

   https://lkml.kernel.org/r/ca965f23256b350ebd94b3dc1a319f28e8267f5f.1643319703.git.zanussi@kernel.org

then I'll just replace the other two.

-- Steve

On Fri, 2022-01-28 at 16:42 -0500, Steven Rostedt wrote:
> On Fri, 28 Jan 2022 14:08:25 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > There were 2 patches in v1 that were flagged by the 0day robot for
> > strncpy off-by-1 warnings:
> > 
> >   tracing: Remove size restriction on hist trigger cmd error
> > logging
> >   tracing: Remove size restriction on synthetic event cmd error
> > logging
> > 
> >   warning: 'strncpy' output truncated before terminating nul
> > copying
> >   as many bytes from a string as its length [-Wstringop-truncation]
> > 
> > This v2 patchset consists of just those two patches with the fix
> > for
> > those warnings.
> 
> 
> So this just replaces the last two patches you sent previously?
> 

Yes.

> Probably would have been better to send all three (since the other 4
> already made it into mainline).
> 

OK, yeah, thought about doing that but guessed wrong, as usual ;-)

> But if "tracing: Remove size restriction on tracing_log_err cmd
> strings" is
> OK:
> 
>    

Yeah, that one is ok as-is without changes.

Tom

> 
https://lkml.kernel.org/r/ca965f23256b350ebd94b3dc1a319f28e8267f5f.1643319703.git.zanussi@kernel.org
> 
> then I'll just replace the other two.
> 
> -- Steve