Hi Steve,

This is an assorted bunch of bugfixes addressing a bugzilla bug,
smatch warnings, and related things I found while fixing those.  In
particular, when looking at the bugzilla bug,
https://bugzilla.kernel.org/show_bug.cgi?id=215513, I noticed that the
err_log output looked truncated and looking further into it found that
it was, because the hist trigger command was very long, exceeding the
256 character limit.

Obviously that's too short, and the final 3 patches remove that
limitation.

Tom

The following changes since commit 4798f3784b1208138e06ab2de65666c19d51ab4d:

  tools/tracing: Update Makefile to build rtla (2022-01-27 11:47:17 -0500)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/misc-bugfixes-v1

Tom Zanussi (7):
  tracing: Fix smatch warning for null glob in
    event_hist_trigger_parse()
  tracing: Fix smatch warning for do while check in
    event_hist_trigger_parse()
  tracing: Propagate is_signed to expression
  tracing: Don't inc err_log entry count if entry allocation fails
  tracing: Remove size restriction on tracing_log_err cmd strings
  tracing: Remove size restriction on hist trigger cmd error logging
  tracing: Remove size restriction on synthetic event cmd error logging

 kernel/trace/trace.c              | 56 ++++++++++++++++++++++++-------
 kernel/trace/trace.h              |  2 +-
 kernel/trace/trace_events_hist.c  | 39 ++++++++++++++++-----
 kernel/trace/trace_events_synth.c | 17 ++++++++--
 4 files changed, 88 insertions(+), 26 deletions(-)

-- 
2.17.1

On Thu, 27 Jan 2022 15:44:14 -0600
Tom Zanussi <zanussi@kernel.org> wrote:

> Hi Steve,
> 
> This is an assorted bunch of bugfixes addressing a bugzilla bug,
> smatch warnings, and related things I found while fixing those.  In
> particular, when looking at the bugzilla bug,
> https://bugzilla.kernel.org/show_bug.cgi?id=215513, I noticed that the
> err_log output looked truncated and looking further into it found that
> it was, because the hist trigger command was very long, exceeding the
> 256 character limit.
> 
> Obviously that's too short, and the final 3 patches remove that
> limitation.

Thanks Tom,

I'm going to run all of them through my tests, but I'm only going to push
the first 4 to Linus for rc, and the limitation limit can wait till the
merge window.

-- Steve

On Thu, 2022-01-27 at 18:26 -0500, Steven Rostedt wrote:
> On Thu, 27 Jan 2022 15:44:14 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > Hi Steve,
> > 
> > This is an assorted bunch of bugfixes addressing a bugzilla bug,
> > smatch warnings, and related things I found while fixing those.  In
> > particular, when looking at the bugzilla bug,
> > https://bugzilla.kernel.org/show_bug.cgi?id=215513, I noticed that
> > the
> > err_log output looked truncated and looking further into it found
> > that
> > it was, because the hist trigger command was very long, exceeding
> > the
> > 256 character limit.
> > 
> > Obviously that's too short, and the final 3 patches remove that
> > limitation.
> 
> Thanks Tom,
> 
> I'm going to run all of them through my tests, but I'm only going to
> push
> the first 4 to Linus for rc, and the limitation limit can wait till
> the
> merge window.
> 

OK, sounds good, thanks.

Tom

> -- Steve