If CONFIG_BITREVERSE is not enabled:

    max6959.c:(.text+0x92): undefined reference to `byte_rev_table'

While at it, sort the existing selects alphabetically

Fixes: a9bcd02fa42217c7 ("auxdisplay: Add driver for MAX695x 7-segment LED controllers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/202502161703.3Vr4M7qg-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/auxdisplay/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 8934e6ad5772b4e0..966a0e1c17e06f2b 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -503,8 +503,9 @@ config HT16K33
 config MAX6959
 	tristate "Maxim MAX6958/6959 7-segment LED controller"
 	depends on I2C
-	select REGMAP_I2C
+	select BITREVERSE
 	select LINEDISP
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for the following Maxim chips
 	  (I2C 7-segment LED display controller):
-- 
2.43.0

On Wed, Feb 19, 2025 at 7:06 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> If CONFIG_BITREVERSE is not enabled:
>
>     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'

Thanks for the fix patch!

> While at it, sort the existing selects alphabetically

In general it seems okay when headers are all generic, but...

...

>  config MAX6959
>         tristate "Maxim MAX6958/6959 7-segment LED controller"
>         depends on I2C
> -       select REGMAP_I2C
> +       select BITREVERSE
>         select LINEDISP
> +       select REGMAP_I2C

...

In this case I prefer to have them kinda grouped, so generic go first
and the subsystem related follows, something like just putting the
BITREVERSE selection before the REGMAP_I2C. With this you don't even
need to add a paragraph to the commit message.

-- 
With Best Regards,
Andy Shevchenko