soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

[PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by Daniel Golle 9 months, 1 week ago

The mtk-socinfo driver uses symbols 'soc_device_register' and
'soc_device_unregister' which are part of the bus driver for
System-on-Chip devices.

Select SOC_BUS to make sure that driver is built and the symbols are
available.

Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
 drivers/soc/mediatek/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
index 50c664b65f4d4..1b7afb19ccd63 100644
--- a/drivers/soc/mediatek/Kconfig
+++ b/drivers/soc/mediatek/Kconfig
@@ -72,6 +72,7 @@ config MTK_SOCINFO
 	tristate "MediaTek SoC Information"
 	default y
 	depends on NVMEM_MTK_EFUSE
+	select SOC_BUS
 	help
 	  The MediaTek SoC Information (mtk-socinfo) driver provides
 	  information about the SoC to the userspace including the
-- 
2.43.0

Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by AngeloGioacchino Del Regno 7 months, 1 week ago

On Wed, 07 Feb 2024 17:42:41 +0000, Daniel Golle wrote:
> The mtk-socinfo driver uses symbols 'soc_device_register' and
> 'soc_device_unregister' which are part of the bus driver for
> System-on-Chip devices.
> 
> Select SOC_BUS to make sure that driver is built and the symbols are
> available.
> 
> [...]

Applied to v6.9-fixes/soc, thanks!

[1/1] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS
      commit: 2217fb42a6d0e062b0a11f90fe775651f73ed05f

Cheers,
Angelo

Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by Matthias Brugger 8 months, 3 weeks ago


On 07/02/2024 18:42, Daniel Golle wrote:
> The mtk-socinfo driver uses symbols 'soc_device_register' and
> 'soc_device_unregister' which are part of the bus driver for
> System-on-Chip devices.
> 
> Select SOC_BUS to make sure that driver is built and the symbols are
> available.
> 
> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/soc/mediatek/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index 50c664b65f4d4..1b7afb19ccd63 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -72,6 +72,7 @@ config MTK_SOCINFO
>   	tristate "MediaTek SoC Information"
>   	default y
>   	depends on NVMEM_MTK_EFUSE
> +	select SOC_BUS
>   	help
>   	  The MediaTek SoC Information (mtk-socinfo) driver provides
>   	  information about the SoC to the userspace including the

Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by Chen-Yu Tsai 8 months, 3 weeks ago

On Thu, Feb 8, 2024 at 1:43 AM Daniel Golle <daniel@makrotopia.org> wrote:
>
> The mtk-socinfo driver uses symbols 'soc_device_register' and
> 'soc_device_unregister' which are part of the bus driver for
> System-on-Chip devices.
>
> Select SOC_BUS to make sure that driver is built and the symbols are
> available.
>
> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

Angelo, I believe this should be picked up for -next?

Also, mediatek/v6.8-next/soc is missing from mediatek/for-next in today's
linux-next.

> ---
>  drivers/soc/mediatek/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> index 50c664b65f4d4..1b7afb19ccd63 100644
> --- a/drivers/soc/mediatek/Kconfig
> +++ b/drivers/soc/mediatek/Kconfig
> @@ -72,6 +72,7 @@ config MTK_SOCINFO
>         tristate "MediaTek SoC Information"
>         default y
>         depends on NVMEM_MTK_EFUSE
> +       select SOC_BUS
>         help
>           The MediaTek SoC Information (mtk-socinfo) driver provides
>           information about the SoC to the userspace including the
> --
> 2.43.0
>
>

Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by AngeloGioacchino Del Regno 8 months, 3 weeks ago

Il 20/02/24 07:40, Chen-Yu Tsai ha scritto:
> On Thu, Feb 8, 2024 at 1:43 AM Daniel Golle <daniel@makrotopia.org> wrote:
>>
>> The mtk-socinfo driver uses symbols 'soc_device_register' and
>> 'soc_device_unregister' which are part of the bus driver for
>> System-on-Chip devices.
>>
>> Select SOC_BUS to make sure that driver is built and the symbols are
>> available.
>>
>> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
>> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> 
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> 
> Angelo, I believe this should be picked up for -next?
> 

I'll pick this up for fixes, as I've already sent the PRs for v6.9.

> Also, mediatek/v6.8-next/soc is missing from mediatek/for-next in today's
> linux-next.
> 

Fixing immediately.

>> ---
>>   drivers/soc/mediatek/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
>> index 50c664b65f4d4..1b7afb19ccd63 100644
>> --- a/drivers/soc/mediatek/Kconfig
>> +++ b/drivers/soc/mediatek/Kconfig
>> @@ -72,6 +72,7 @@ config MTK_SOCINFO
>>          tristate "MediaTek SoC Information"
>>          default y
>>          depends on NVMEM_MTK_EFUSE
>> +       select SOC_BUS
>>          help
>>            The MediaTek SoC Information (mtk-socinfo) driver provides
>>            information about the SoC to the userspace including the
>> --
>> 2.43.0
>>
>>

Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by Chen-Yu Tsai 8 months, 3 weeks ago

On Tue, Feb 20, 2024 at 4:56 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 20/02/24 07:40, Chen-Yu Tsai ha scritto:
> > On Thu, Feb 8, 2024 at 1:43 AM Daniel Golle <daniel@makrotopia.org> wrote:
> >>
> >> The mtk-socinfo driver uses symbols 'soc_device_register' and
> >> 'soc_device_unregister' which are part of the bus driver for
> >> System-on-Chip devices.
> >>
> >> Select SOC_BUS to make sure that driver is built and the symbols are
> >> available.
> >>
> >> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
> >> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> >
> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> >
> > Angelo, I believe this should be picked up for -next?
> >
>
> I'll pick this up for fixes, as I've already sent the PRs for v6.9.

The socinfo driver is in -next, so I guess you could pick it up as a fix
for v6.9.

ChenYu

> > Also, mediatek/v6.8-next/soc is missing from mediatek/for-next in today's
> > linux-next.
> >
>
> Fixing immediately.
>
> >> ---
> >>   drivers/soc/mediatek/Kconfig | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> >> index 50c664b65f4d4..1b7afb19ccd63 100644
> >> --- a/drivers/soc/mediatek/Kconfig
> >> +++ b/drivers/soc/mediatek/Kconfig
> >> @@ -72,6 +72,7 @@ config MTK_SOCINFO
> >>          tristate "MediaTek SoC Information"
> >>          default y
> >>          depends on NVMEM_MTK_EFUSE
> >> +       select SOC_BUS
> >>          help
> >>            The MediaTek SoC Information (mtk-socinfo) driver provides
> >>            information about the SoC to the userspace including the
> >> --
> >> 2.43.0
> >>
> >>
>
>

Re: [PATCH] soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS

Posted by AngeloGioacchino Del Regno 8 months, 3 weeks ago

Il 20/02/24 10:03, Chen-Yu Tsai ha scritto:
> On Tue, Feb 20, 2024 at 4:56 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Il 20/02/24 07:40, Chen-Yu Tsai ha scritto:
>>> On Thu, Feb 8, 2024 at 1:43 AM Daniel Golle <daniel@makrotopia.org> wrote:
>>>>
>>>> The mtk-socinfo driver uses symbols 'soc_device_register' and
>>>> 'soc_device_unregister' which are part of the bus driver for
>>>> System-on-Chip devices.
>>>>
>>>> Select SOC_BUS to make sure that driver is built and the symbols are
>>>> available.
>>>>
>>>> Fixes: 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
>>>> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>>>
>>> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>>>
>>> Angelo, I believe this should be picked up for -next?
>>>
>>
>> I'll pick this up for fixes, as I've already sent the PRs for v6.9.
> 
> The socinfo driver is in -next, so I guess you could pick it up as a fix
> for v6.9.
> 

Of course! :-)

Cheers,
Angelo

> ChenYu
> 
>>> Also, mediatek/v6.8-next/soc is missing from mediatek/for-next in today's
>>> linux-next.
>>>
>>
>> Fixing immediately.
>>
>>>> ---
>>>>    drivers/soc/mediatek/Kconfig | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
>>>> index 50c664b65f4d4..1b7afb19ccd63 100644
>>>> --- a/drivers/soc/mediatek/Kconfig
>>>> +++ b/drivers/soc/mediatek/Kconfig
>>>> @@ -72,6 +72,7 @@ config MTK_SOCINFO
>>>>           tristate "MediaTek SoC Information"
>>>>           default y
>>>>           depends on NVMEM_MTK_EFUSE
>>>> +       select SOC_BUS
>>>>           help
>>>>             The MediaTek SoC Information (mtk-socinfo) driver provides
>>>>             information about the SoC to the userspace including the
>>>> --
>>>> 2.43.0
>>>>
>>>>
>>
>>