drivers/block/loop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Commit 08e136ebd193 ("loop: don't change loop device under exclusive
opener in loop_set_status") forgot to call bd_abort_claiming() when
mutex_lock_killable() failed.
Fixes: 08e136ebd193 ("loop: don't change loop device under exclusive opener in loop_set_status")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
Since that commit for some reason calls loop_reread_partitions() when
bd_prepare_to_claim() failed, this patch calls loop_reread_partitions()
when mutex_lock_killable() failed after bd_abort_claiming()...
Maybe we should return as soon as possible?
drivers/block/loop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index ca74cc31bf07f..bd59c0e9508b7 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1245,7 +1245,8 @@ loop_set_status(struct loop_device *lo, blk_mode_t mode,
err = mutex_lock_killable(&lo->lo_mutex);
if (err)
- return err;
+ goto out_abort_claiming;
+
if (lo->lo_state != Lo_bound) {
err = -ENXIO;
goto out_unlock;
@@ -1284,6 +1285,7 @@ loop_set_status(struct loop_device *lo, blk_mode_t mode,
}
out_unlock:
mutex_unlock(&lo->lo_mutex);
+out_abort_claiming:
if (!(mode & BLK_OPEN_EXCL))
bd_abort_claiming(bdev, loop_set_status);
out_reread_partitions:
--
2.47.3
On Wed, 07 Jan 2026 19:41:43 +0900, Tetsuo Handa wrote:
> Commit 08e136ebd193 ("loop: don't change loop device under exclusive
> opener in loop_set_status") forgot to call bd_abort_claiming() when
> mutex_lock_killable() failed.
>
>
Applied, thanks!
[1/1] loop: add missing bd_abort_claiming in loop_set_status
commit: 2704024d83fa9eb8e5f16925aae340fd9d246694
Best regards,
--
Jens Axboe
© 2016 - 2026 Red Hat, Inc.