pinctrl: Join split messages and remove double whitespace

[PATCH] pinctrl: Join split messages and remove double whitespace

Posted by Geert Uytterhoeven 1 year, 5 months ago

Splitting error messages across multiple lines makes it harder to find
them in the kernel sources.  Fix this by joining the messages.
Remove double whitespace (end of first line + begin of second line).

Fixes: 1c8e794432c2ee75 ("pinctrl: improve warning messages")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/pinmux.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index aae71a37219b26ff..02033ea1c643842c 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -442,8 +442,7 @@ int pinmux_enable_setting(const struct pinctrl_setting *setting)
 			gname = pctlops->get_group_name(pctldev,
 						setting->data.mux.group);
 			dev_err_probe(pctldev->dev, ret,
-				"could not request pin %d (%s) from group %s "
-				" on device %s\n",
+				"could not request pin %d (%s) from group %s on device %s\n",
 				pins[i], pname, gname,
 				pinctrl_dev_get_name(pctldev));
 			goto err_pin_request;
@@ -526,9 +525,7 @@ void pinmux_disable_setting(const struct pinctrl_setting *setting)
 			gname = pctlops->get_group_name(pctldev,
 						setting->data.mux.group);
 			dev_warn(pctldev->dev,
-				 "not freeing pin %d (%s) as part of "
-				 "deactivating group %s - it is already "
-				 "used for some other setting",
+				 "not freeing pin %d (%s) as part of deactivating group %s - it is already used for some other setting",
 				 pins[i], desc->name, gname);
 		}
 	}
-- 
2.34.1

Re: [PATCH] pinctrl: Join split messages and remove double whitespace

Posted by Linus Walleij 1 year, 5 months ago

On Thu, Aug 29, 2024 at 3:30 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> Splitting error messages across multiple lines makes it harder to find
> them in the kernel sources.  Fix this by joining the messages.
> Remove double whitespace (end of first line + begin of second line).
>
> Fixes: 1c8e794432c2ee75 ("pinctrl: improve warning messages")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Patch applied!

Yours,
Linus Walleij