[PATCH] powerpc/4xx: Add missing includes to fix no previous prototype errors

Christophe Leroy posted 1 patch 2 years, 4 months ago
arch/powerpc/platforms/4xx/soc.c | 1 +
arch/powerpc/platforms/4xx/uic.c | 1 +
2 files changed, 2 insertions(+)
[PATCH] powerpc/4xx: Add missing includes to fix no previous prototype errors
Posted by Christophe Leroy 2 years, 4 months ago
A W=1 build of ppc40x_defconfig throws the followings errors:

  CC      arch/powerpc/platforms/4xx/uic.o
arch/powerpc/platforms/4xx/uic.c:274:13: warning: no previous prototype for 'uic_init_tree' [-Wmissing-prototypes]
  274 | void __init uic_init_tree(void)
      |             ^~~~~~~~~~~~~
arch/powerpc/platforms/4xx/uic.c:319:14: warning: no previous prototype for 'uic_get_irq' [-Wmissing-prototypes]
  319 | unsigned int uic_get_irq(void)
      |              ^~~~~~~~~~~
  CC      arch/powerpc/platforms/4xx/machine_check.o
  CC      arch/powerpc/platforms/4xx/soc.o
arch/powerpc/platforms/4xx/soc.c:193:6: warning: no previous prototype for 'ppc4xx_reset_system' [-Wmissing-prototypes]
  193 | void ppc4xx_reset_system(char *cmd)
      |      ^~~~~~~~~~~~~~~~~~~

Add missing includes to get the missing prototypes.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 arch/powerpc/platforms/4xx/soc.c | 1 +
 arch/powerpc/platforms/4xx/uic.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/4xx/soc.c b/arch/powerpc/platforms/4xx/soc.c
index f91df0827877..b2d940437a66 100644
--- a/arch/powerpc/platforms/4xx/soc.c
+++ b/arch/powerpc/platforms/4xx/soc.c
@@ -21,6 +21,7 @@
 #include <asm/dcr.h>
 #include <asm/dcr-regs.h>
 #include <asm/reg.h>
+#include <asm/ppc4xx.h>
 
 static u32 dcrbase_l2c;
 
diff --git a/arch/powerpc/platforms/4xx/uic.c b/arch/powerpc/platforms/4xx/uic.c
index d667ad039bd3..e3e148b9dd18 100644
--- a/arch/powerpc/platforms/4xx/uic.c
+++ b/arch/powerpc/platforms/4xx/uic.c
@@ -24,6 +24,7 @@
 #include <asm/irq.h>
 #include <asm/io.h>
 #include <asm/dcr.h>
+#include <asm/uic.h>
 
 #define NR_UIC_INTS	32
 
-- 
2.41.0
Re: [PATCH] powerpc/4xx: Add missing includes to fix no previous prototype errors
Posted by Michael Ellerman 2 years, 3 months ago
On Thu, 17 Aug 2023 16:27:23 +0200, Christophe Leroy wrote:
> A W=1 build of ppc40x_defconfig throws the followings errors:
> 
>   CC      arch/powerpc/platforms/4xx/uic.o
> arch/powerpc/platforms/4xx/uic.c:274:13: warning: no previous prototype for 'uic_init_tree' [-Wmissing-prototypes]
>   274 | void __init uic_init_tree(void)
>       |             ^~~~~~~~~~~~~
> arch/powerpc/platforms/4xx/uic.c:319:14: warning: no previous prototype for 'uic_get_irq' [-Wmissing-prototypes]
>   319 | unsigned int uic_get_irq(void)
>       |              ^~~~~~~~~~~
>   CC      arch/powerpc/platforms/4xx/machine_check.o
>   CC      arch/powerpc/platforms/4xx/soc.o
> arch/powerpc/platforms/4xx/soc.c:193:6: warning: no previous prototype for 'ppc4xx_reset_system' [-Wmissing-prototypes]
>   193 | void ppc4xx_reset_system(char *cmd)
>       |      ^~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/4xx: Add missing includes to fix no previous prototype errors
      https://git.kernel.org/powerpc/c/7dac7cf1b407605c15d85ae885377ba0560ca4cd

cheers