[PATCH] staging: rtl8723bs: replace kzalloc/kmalloc+memcpy with kmemdup

Alexandru Hossu posted 1 patch 1 month, 1 week ago
There is a newer version of this series
drivers/staging/rtl8723bs/hal/sdio_ops.c          | 4 +---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
[PATCH] staging: rtl8723bs: replace kzalloc/kmalloc+memcpy with kmemdup
Posted by Alexandru Hossu 1 month, 1 week ago
Replace kzalloc/kmalloc followed by memcpy with kmemdup to simplify
code and avoid unnecessary zero-initialization before overwriting.

Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>From 3ed44dff9cee65557deb3221402a9f8f9cb9957f Mon Sep 17 00:00:00 2001
From: Alexandru Hossu <hossu.alexandru@gmail.com>
Date: Wed, 4 Mar 2026 12:24:33 +0100
Subject: [PATCH] staging: rtl8723bs: replace kzalloc/kmalloc+memcpy with
 kmemdup

Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c          | 4 +---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index c9cb20c61..514c857a9 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -583,12 +583,10 @@ s32 sdio_local_write(
 	)
 		return sd_cmd52_write(intfhdl, addr, cnt, buf);
 
-	tmpbuf = kmalloc(cnt, GFP_ATOMIC);
+	tmpbuf = kmemdup(buf, cnt, GFP_ATOMIC);
 	if (!tmpbuf)
 		return -ENOMEM;
 
-	memcpy(tmpbuf, buf, cnt);
-
 	err = sd_write(intfhdl, addr, cnt, tmpbuf);
 
 	kfree(tmpbuf);
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 7cb0c6f22..2125606f7 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1430,14 +1430,12 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel
 		goto exit;
 	}
 
-	buf = kzalloc(ielen, GFP_KERNEL);
+	buf = kmemdup(pie, ielen, GFP_KERNEL);
 	if (!buf) {
 		ret =  -ENOMEM;
 		goto exit;
 	}
 
-	memcpy(buf, pie, ielen);
-
 	if (ielen < RSN_HEADER_LEN) {
 		ret  = -1;
 		goto exit;
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: replace kzalloc/kmalloc+memcpy with kmemdup
Posted by Dan Carpenter 1 month, 1 week ago
On Wed, Mar 04, 2026 at 12:26:38PM +0100, Alexandru Hossu wrote:
> Replace kzalloc/kmalloc followed by memcpy with kmemdup to simplify
> code and avoid unnecessary zero-initialization before overwriting.
> 
> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>


Please slow down.  Also work against staging-next or linux-next.

regards,
dan carpenter