mtd: rawnand: sunxi: Convert to common field_{get,prep}() helpers

[PATCH v7] mtd: rawnand: sunxi: Convert to common field_{get,prep}() helpers

Posted by Geert Uytterhoeven 3 weeks, 3 days ago

Drop the driver-specific field_get() and field_prep() macros, in favor
of the globally available variants from <linux/bitfield.h>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
v7:
  - Add Acked-by,

v6:
  - New.
---
 drivers/mtd/nand/raw/sunxi_nand.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index 9dcdc93734cbff39..e66adfcca7cd63fb 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -29,12 +29,6 @@
 #include <linux/iopoll.h>
 #include <linux/reset.h>
 
-/* non compile-time field get/prep */
-#undef field_get
-#define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
-#undef field_prep
-#define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
-
 #define NFC_REG_CTL		0x0000
 #define NFC_REG_ST		0x0004
 #define NFC_REG_INT		0x0008
-- 
2.43.0

Re: [PATCH v7] mtd: rawnand: sunxi: Convert to common field_{get,prep}() helpers

Posted by Miquel Raynal 2 weeks, 3 days ago

Hi Geert,

On 15/01/2026 at 15:26:22 +01, Geert Uytterhoeven <geert+renesas@glider.be> wrote:

> Drop the driver-specific field_get() and field_prep() macros, in favor
> of the globally available variants from <linux/bitfield.h>.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

I think b4 didn't catch up that I applied this patch (in the wrong
branch, then moved it manually), so in case I indeed did not send a
formal "applied to the MTD tree" yet, here it is :-)

Cheers,
Miquèl

Re: [PATCH v7] mtd: rawnand: sunxi: Convert to common field_{get,prep}() helpers

Posted by Geert Uytterhoeven 2 weeks, 3 days ago

Hi Miquèl,

On Thu, 22 Jan 2026 at 15:07, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> On 15/01/2026 at 15:26:22 +01, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > Drop the driver-specific field_get() and field_prep() macros, in favor
> > of the globally available variants from <linux/bitfield.h>.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> I think b4 didn't catch up that I applied this patch (in the wrong
> branch, then moved it manually), so in case I indeed did not send a
> formal "applied to the MTD tree" yet, here it is :-)

No worries, I^Wmy scripting had noticed ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds