platforms: 52xx: Remove space after '(' and before ')'

[PATCH] platforms: 52xx: Remove space after '(' and before ')'

Posted by hanyu001@208suo.com 2 years, 6 months ago

The patch fixes the following errors detected by checkpatch:

platforms/52xx/mpc52xx_pci.c:346:ERROR: space prohibited after that open 
parenthesis '('
platforms/52xx/mpc52xx_pci.c:347:ERROR: space prohibited after that open 
parenthesis '('
platforms/52xx/mpc52xx_pci.c:348:ERROR: space prohibited before that 
close parenthesis ')'

Signed-off-by: Yu Han <hanyu001@208suo.com>
---
  arch/powerpc/platforms/52xx/mpc52xx_pci.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pci.c 
b/arch/powerpc/platforms/52xx/mpc52xx_pci.c
index 0ca4401ba781..452723f8ba53 100644
--- a/arch/powerpc/platforms/52xx/mpc52xx_pci.c
+++ b/arch/powerpc/platforms/52xx/mpc52xx_pci.c
@@ -343,9 +343,9 @@ mpc52xx_pci_fixup_resources(struct pci_dev *dev)

      /* The PCI Host bridge of MPC52xx has a prefetch memory resource
         fixed to 1Gb. Doesn't fit in the resource system so we remove it 
*/
-    if ( (dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
-         (   dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
-          || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B) ) {
+    if ((dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
+         (dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
+          || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B)) {
          struct resource *res = &dev->resource[1];
          res->start = res->end = res->flags = 0;
      }

Re: [PATCH] platforms: 52xx: Remove space after '(' and before ')'

Posted by Andy Shevchenko 2 years, 6 months ago

On Tue, Jul 18, 2023 at 05:02:39PM +0800, hanyu001@208suo.com wrote:
> The patch fixes the following errors detected by checkpatch:
> 
> platforms/52xx/mpc52xx_pci.c:346:ERROR: space prohibited after that open
> parenthesis '('
> platforms/52xx/mpc52xx_pci.c:347:ERROR: space prohibited after that open
> parenthesis '('
> platforms/52xx/mpc52xx_pci.c:348:ERROR: space prohibited before that close
> parenthesis ')'

First of all, your patch is mangled and may not be applied.
Second, we usually don't do this kind of patches at all.
Besides the fact that we don't run checkpatch on the files
which are already in upstream (esp. so-o-o old as this one).

NAK.

...

> +    if ((dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
> +         (dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
> +          || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B)) {

Also note, you can move this to use pci_match_id().
That kind of patch might be approved.

-- 
With Best Regards,
Andy Shevchenko