mailbox: RISCV_SBI_MPXY_MBOX should be disabled by default

[PATCH] mailbox: RISCV_SBI_MPXY_MBOX should be disabled by default

Posted by Geert Uytterhoeven 4 months, 1 week ago

The help text for RISC-V SBI Message Proxy (MPXY) Mailbox support states
"If unsure say N", so the driver should not default to enabled.

Fixes: bf3022a4eb119c6b ("mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/mailbox/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index c488725aa2a5d4b0..acc4bd93136cb720 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -372,7 +372,6 @@ config BCM74110_MAILBOX
 config RISCV_SBI_MPXY_MBOX
 	tristate "RISC-V SBI Message Proxy (MPXY) Mailbox"
 	depends on RISCV_SBI
-	default RISCV
 	help
 	  Mailbox driver implementation for RISC-V SBI Message Proxy (MPXY)
 	  extension. This mailbox driver is used to send messages to the
-- 
2.43.0

Re: [PATCH] mailbox: RISCV_SBI_MPXY_MBOX should be disabled by default

Posted by Anup Patel 4 months, 1 week ago

On Tue, Sep 30, 2025 at 8:19 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The help text for RISC-V SBI Message Proxy (MPXY) Mailbox support states
> "If unsure say N", so the driver should not default to enabled.

This is a very critical RISC-V driver providing mailbox channels to
other drivers such as clock, system MSIs, etc.

I suggest changing the config description instead of changing to
not enabled by default.

Regards,
Anup

>
> Fixes: bf3022a4eb119c6b ("mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/mailbox/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index c488725aa2a5d4b0..acc4bd93136cb720 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -372,7 +372,6 @@ config BCM74110_MAILBOX
>  config RISCV_SBI_MPXY_MBOX
>         tristate "RISC-V SBI Message Proxy (MPXY) Mailbox"
>         depends on RISCV_SBI
> -       default RISCV
>         help
>           Mailbox driver implementation for RISC-V SBI Message Proxy (MPXY)
>           extension. This mailbox driver is used to send messages to the
> --
> 2.43.0
>
>