[PATCH] clk: hisilicon: hi3519: Release the correct number of gates in hi3519_clk_unregister()

Christophe JAILLET posted 1 patch 1 year, 11 months ago
drivers/clk/hisilicon/clk-hi3519.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] clk: hisilicon: hi3519: Release the correct number of gates in hi3519_clk_unregister()
Posted by Christophe JAILLET 1 year, 11 months ago
The gates are stored in 'hi3519_gate_clks', not 'hi3519_mux_clks'.
This is also in line with how hisi_clk_register_gate() is called in the
probe.

Fixes: 224b3b262c52 ("clk: hisilicon: hi3519: add driver remove path and fix some issues")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/clk/hisilicon/clk-hi3519.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
index b871872d9960..141b727ff60d 100644
--- a/drivers/clk/hisilicon/clk-hi3519.c
+++ b/drivers/clk/hisilicon/clk-hi3519.c
@@ -130,7 +130,7 @@ static void hi3519_clk_unregister(struct platform_device *pdev)
 	of_clk_del_provider(pdev->dev.of_node);
 
 	hisi_clk_unregister_gate(hi3519_gate_clks,
-				ARRAY_SIZE(hi3519_mux_clks),
+				ARRAY_SIZE(hi3519_gate_clks),
 				crg->clk_data);
 	hisi_clk_unregister_mux(hi3519_mux_clks,
 				ARRAY_SIZE(hi3519_mux_clks),
-- 
2.34.1
Re: [PATCH] clk: hisilicon: hi3519: Release the correct number of gates in hi3519_clk_unregister()
Posted by Stephen Boyd 1 year, 10 months ago
Quoting Christophe JAILLET (2024-01-10 10:58:21)
> The gates are stored in 'hi3519_gate_clks', not 'hi3519_mux_clks'.
> This is also in line with how hisi_clk_register_gate() is called in the
> probe.
> 
> Fixes: 224b3b262c52 ("clk: hisilicon: hi3519: add driver remove path and fix some issues")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Applied to clk-next