[v1] powerpc/mpic: Use bitmap_zalloc() when applicable

[PATCH] powerpc/mpic: Use bitmap_zalloc() when applicable

Posted by Christophe JAILLET 4 years, 6 months ago

'mpic->protected' is a bitmap. So use 'bitmap_zalloc()' to simplify
code and improve the semantic, instead of hand writing it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/s390/cio/idset.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c
index 45f9c0736be4..7e5550230c0f 100644
--- a/drivers/s390/cio/idset.c
+++ b/drivers/s390/cio/idset.c
@@ -25,11 +25,10 @@ static struct idset *idset_new(int num_ssid, int num_id)
 {
 	struct idset *set;
 
-	set = vmalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
+	set = vzalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
 	if (set) {
 		set->num_ssid = num_ssid;
 		set->num_id = num_id;
-		memset(set->bitmap, 0, bitmap_size(num_ssid, num_id));
 	}
 	return set;
 }
-- 
2.30.2

Re: [PATCH] powerpc/mpic: Use bitmap_zalloc() when applicable

Posted by Christophe JAILLET 4 years, 6 months ago

Le 17/12/2021 à 22:37, Christophe JAILLET a écrit :
> 'mpic->protected' is a bitmap. So use 'bitmap_zalloc()' to simplify
> code and improve the semantic, instead of hand writing it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/s390/cio/idset.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c
> index 45f9c0736be4..7e5550230c0f 100644
> --- a/drivers/s390/cio/idset.c
> +++ b/drivers/s390/cio/idset.c
> @@ -25,11 +25,10 @@ static struct idset *idset_new(int num_ssid, int num_id)
>   {
>   	struct idset *set;
>   
> -	set = vmalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
> +	set = vzalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
>   	if (set) {
>   		set->num_ssid = num_ssid;
>   		set->num_id = num_id;
> -		memset(set->bitmap, 0, bitmap_size(num_ssid, num_id));
>   	}
>   	return set;
>   }
> 
NACK,

my git GUI played me some tricks.
Wrong patch attached :(

CJ