[PATCH v2] block: sed-opal: Don't include <linux/kernel.h>

Christophe JAILLET posted 1 patch 2 years, 9 months ago
include/linux/sed-opal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH v2] block: sed-opal: Don't include <linux/kernel.h>
Posted by Christophe JAILLET 2 years, 9 months ago
There is no need to include <linux/kernel.h> here.

Prefer the less invasive <linux/types.h> and <linux/compiler_types.h>
which are needed in this .h file itself.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Change in v2:
  * No need to add a useless comment    [Christoph Hellwig]
  * No need to add a new empty line     [Christoph Hellwig]

v1: https://lore.kernel.org/all/a2de79b3de30fe70c457953af935dadd49441f00.1670069909.git.christophe.jaillet@wanadoo.fr/

Let see if build-bots agree with me!
---
 include/linux/sed-opal.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/linux/sed-opal.h b/include/linux/sed-opal.h
index 6f837bb6c715..87f981c70894 100644
--- a/include/linux/sed-opal.h
+++ b/include/linux/sed-opal.h
@@ -11,7 +11,8 @@
 #define LINUX_OPAL_H
 
 #include <uapi/linux/sed-opal.h>
-#include <linux/kernel.h>
+#include <linux/compiler_types.h>
+#include <linux/types.h>
 
 struct opal_dev;
 
-- 
2.34.1
Re: [PATCH v2] block: sed-opal: Don't include <linux/kernel.h>
Posted by Christoph Hellwig 2 years, 9 months ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>