t-next net: netlink: Remove the dump_cb_mutex field from struct netlink_sock

[PATCH ne]t-next net: netlink: Remove the dump_cb_mutex field from struct netlink_sock

Posted by Christophe JAILLET 1 year, 5 months ago

Commit 5fbf57a937f4 ("net: netlink: remove the cb_mutex "injection" from
netlink core") has removed the usage of the 'dump_cb_mutex' field from the
struct netlink_sock.

Remove the field itself now. It saves a few bytes in the structure.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only
---
 net/netlink/af_netlink.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/netlink/af_netlink.h b/net/netlink/af_netlink.h
index 9751e29d4bbb..5b0e4e62ab8b 100644
--- a/net/netlink/af_netlink.h
+++ b/net/netlink/af_netlink.h
@@ -41,7 +41,6 @@ struct netlink_sock {
 	struct netlink_callback	cb;
 	struct mutex		nl_cb_mutex;
 
-	struct mutex		*dump_cb_mutex;
 	void			(*netlink_rcv)(struct sk_buff *skb);
 	int			(*netlink_bind)(struct net *net, int group);
 	void			(*netlink_unbind)(struct net *net, int group);
-- 
2.46.0

Re: [PATCH ne]t-next net: netlink: Remove the dump_cb_mutex field from struct netlink_sock

Posted by Christophe JAILLET 1 year, 5 months ago

Le 22/08/2024 à 08:48, Christophe JAILLET a écrit :
> Commit 5fbf57a937f4 ("net: netlink: remove the cb_mutex "injection" from
> netlink core") has removed the usage of the 'dump_cb_mutex' field from the
> struct netlink_sock.
> 
> Remove the field itself now. It saves a few bytes in the structure.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
>   net/netlink/af_netlink.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/netlink/af_netlink.h b/net/netlink/af_netlink.h
> index 9751e29d4bbb..5b0e4e62ab8b 100644
> --- a/net/netlink/af_netlink.h
> +++ b/net/netlink/af_netlink.h
> @@ -41,7 +41,6 @@ struct netlink_sock {
>   	struct netlink_callback	cb;
>   	struct mutex		nl_cb_mutex;
>   
> -	struct mutex		*dump_cb_mutex;
>   	void			(*netlink_rcv)(struct sk_buff *skb);
>   	int			(*netlink_bind)(struct net *net, int group);
>   	void			(*netlink_unbind)(struct net *net, int group);

Sorry for the broken subject, I'll resend.

CJ