wireless: ralink: rt2x00: Remove unnecessary spaces

[PATCH] wireless: ralink: rt2x00: Remove unnecessary spaces

Posted by hanyu001@208suo.com 2 years, 6 months ago

Fix checkpatch warnings:

./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space 
prohibited after that open parenthesis '('
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space 
prohibited before that close parenthesis ')'
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space 
prohibited after that open parenthesis '('
./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space 
prohibited before that close parenthesis ')'

Signed-off-by: Yu Han <hanyu001@208suo.com>
---
  drivers/net/wireless/ralink/rt2x00/rt2x00reg.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h 
b/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
index ffe802b..0e5094a 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00reg.h
@@ -165,8 +165,8 @@ struct rt2x00_field32 {
   * Note that we cannot use the is_power_of_2() function since this
   * check must be done at compile-time.
   */
-#define is_power_of_two(x)    ( !((x) & ((x)-1)) )
-#define low_bit_mask(x)        ( ((x)-1) & ~(x) )
+#define is_power_of_two(x)    (!((x) & ((x)-1)))
+#define low_bit_mask(x)        (((x)-1) & ~(x))
  #define is_valid_mask(x)    is_power_of_two(1LU + (x) + 
low_bit_mask(x))

  /*

Re: [PATCH] wireless: ralink: rt2x00: Remove unnecessary spaces

Posted by Kalle Valo 2 years, 6 months ago

hanyu001@208suo.com writes:

> Fix checkpatch warnings:
>
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space
> prohibited after that open parenthesis '('
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:168: ERROR: space
> prohibited before that close parenthesis ')'
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space
> prohibited after that open parenthesis '('
> ./drivers/net/wireless/ralink/rt2x00/rt2x00reg.h:169: ERROR: space
> prohibited before that close parenthesis ')'
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>

I have seen a lot of checkpatch fixes from you. We do not really like
random checkpatch fixes from new people, too much work for very little
gain. From looking at the title it's clear that you have not even read
our wireless specific instructions from our wiki (see link below).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches