powerpc: pmac32: enable serial options by default in defconfig

[PATCH] powerpc: pmac32: enable serial options by default in defconfig

Posted by Yuan Tan 2 years, 6 months ago

Serial is a critical feature for logging and debuging, and the other
architectures enable serial by default.

Let's enable CONFIG_SERIAL_PMACZILOG and CONFIG_SERIAL_PMACZILOG_CONSOLE
by default.

Signed-off-by: Yuan Tan <tanyuan@tinylab.org>
---
 arch/powerpc/configs/pmac32_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
index 019163c2571e..3aae79afb9d9 100644
--- a/arch/powerpc/configs/pmac32_defconfig
+++ b/arch/powerpc/configs/pmac32_defconfig
@@ -176,8 +176,9 @@ CONFIG_MOUSE_APPLETOUCH=y
 # CONFIG_SERIO_I8042 is not set
 # CONFIG_SERIO_SERPORT is not set
 CONFIG_SERIAL_8250=m
-CONFIG_SERIAL_PMACZILOG=m
+CONFIG_SERIAL_PMACZILOG=y
 CONFIG_SERIAL_PMACZILOG_TTYS=y
+CONFIG_SERIAL_PMACZILOG_CONSOLE=y
 CONFIG_NVRAM=y
 CONFIG_I2C_CHARDEV=m
 CONFIG_APM_POWER=y
-- 
2.34.1

Re: [PATCH] powerpc: pmac32: enable serial options by default in defconfig

Posted by Michael Ellerman 2 years, 5 months ago

On Wed, 02 Aug 2023 21:41:30 +0800, Yuan Tan wrote:
> Serial is a critical feature for logging and debuging, and the other
> architectures enable serial by default.
> 
> Let's enable CONFIG_SERIAL_PMACZILOG and CONFIG_SERIAL_PMACZILOG_CONSOLE
> by default.
> 
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc: pmac32: enable serial options by default in defconfig
      https://git.kernel.org/powerpc/c/0b5e06e9cb156e7e97bfb4e1ebf6acd62497eaf5

cheers

Re: [PATCH] powerpc: pmac32: enable serial options by default in defconfig

Posted by Christophe Leroy 2 years, 6 months ago


Le 02/08/2023 à 15:41, Yuan Tan a écrit :
> [Vous ne recevez pas souvent de courriers de tanyuan@tinylab.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Serial is a critical feature for logging and debuging, and the other
> architectures enable serial by default.
> 
> Let's enable CONFIG_SERIAL_PMACZILOG and CONFIG_SERIAL_PMACZILOG_CONSOLE
> by default.
> 
> Signed-off-by: Yuan Tan <tanyuan@tinylab.org>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
>   arch/powerpc/configs/pmac32_defconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
> index 019163c2571e..3aae79afb9d9 100644
> --- a/arch/powerpc/configs/pmac32_defconfig
> +++ b/arch/powerpc/configs/pmac32_defconfig
> @@ -176,8 +176,9 @@ CONFIG_MOUSE_APPLETOUCH=y
>   # CONFIG_SERIO_I8042 is not set
>   # CONFIG_SERIO_SERPORT is not set
>   CONFIG_SERIAL_8250=m
> -CONFIG_SERIAL_PMACZILOG=m
> +CONFIG_SERIAL_PMACZILOG=y
>   CONFIG_SERIAL_PMACZILOG_TTYS=y
> +CONFIG_SERIAL_PMACZILOG_CONSOLE=y
>   CONFIG_NVRAM=y
>   CONFIG_I2C_CHARDEV=m
>   CONFIG_APM_POWER=y
> --
> 2.34.1
>

Re: [PATCH] powerpc: pmac32: enable serial options by default in defconfig

Posted by Yuan Tan 2 years, 6 months ago

Hi Christophe

On 8/2/2023 9:58 PM, Christophe Leroy wrote:
>
> Le 02/08/2023 à 15:41, Yuan Tan a écrit :
>> [Vous ne recevez pas souvent de courriers de tanyuan@tinylab.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Serial is a critical feature for logging and debuging, and the other
>> architectures enable serial by default.
>>
>> Let's enable CONFIG_SERIAL_PMACZILOG and CONFIG_SERIAL_PMACZILOG_CONSOLE
>> by default.
>>
>> Signed-off-by: Yuan Tan <tanyuan@tinylab.org>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

Can this patch be merged into v6.6? There's another patch depends on it :)

Best regards,

Yuan Tan

>> ---
>>    arch/powerpc/configs/pmac32_defconfig | 3 ++-
>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/configs/pmac32_defconfig b/arch/powerpc/configs/pmac32_defconfig
>> index 019163c2571e..3aae79afb9d9 100644
>> --- a/arch/powerpc/configs/pmac32_defconfig
>> +++ b/arch/powerpc/configs/pmac32_defconfig
>> @@ -176,8 +176,9 @@ CONFIG_MOUSE_APPLETOUCH=y
>>    # CONFIG_SERIO_I8042 is not set
>>    # CONFIG_SERIO_SERPORT is not set
>>    CONFIG_SERIAL_8250=m
>> -CONFIG_SERIAL_PMACZILOG=m
>> +CONFIG_SERIAL_PMACZILOG=y
>>    CONFIG_SERIAL_PMACZILOG_TTYS=y
>> +CONFIG_SERIAL_PMACZILOG_CONSOLE=y
>>    CONFIG_NVRAM=y
>>    CONFIG_I2C_CHARDEV=m
>>    CONFIG_APM_POWER=y
>> --
>> 2.34.1
>>